Use PiecewiseSequence for List take elements#8833
Draft
danking wants to merge 4 commits into
Draft
Conversation
Merging this PR will improve performance by 27.05%
Performance ChangesTip Curious why this is faster? Comment Comparing Footnotes
|
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:05
c4a0358 to
c76531d
Compare
danking
force-pushed
the
codex/list-take-piecewise-elements
branch
2 times, most recently
from
July 17, 2026 20:15
77d37d8 to
b7ad4df
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:19
80f7b89 to
30870aa
Compare
danking
force-pushed
the
codex/list-take-piecewise-elements
branch
from
July 17, 2026 20:19
b7ad4df to
f0eec2d
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:25
30870aa to
e777ab4
Compare
danking
force-pushed
the
codex/list-take-piecewise-elements
branch
from
July 17, 2026 20:25
f0eec2d to
d40cee8
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:37
e777ab4 to
e4a0543
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
codex/list-take-piecewise-elements
branch
from
July 17, 2026 20:40
d40cee8 to
e781b61
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a simplification. List::take already had a specialized implementation. The new PiecewiseSequence specializations in various primitive arrays supersede this change.
EDIT: Heh, I guess the PiecewiseSequence stuff is actually even faster than old List::take. Nice.
codex:
Summary
Validation