-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
gh-140146: Fix for stdin redirection to a pipe with interactive tkinter on Windows #148819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka
merged 9 commits into
python:main
from
mdehoon:issue140146_fix_for_windows_pipe
Jun 29, 2026
+83
−7
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cdec347
fix for issue 140146
mdehoon 00962ca
add blurb
mdehoon ea84b7b
add one test
mdehoon 004b0cd
Merge branch 'main' into issue140146_fix_for_windows_pipe
mdehoon 5bc255b
Update _tkinter.c to remove errorInCmd
mdehoon b524821
Add an arm for FILE_TYPE_DISK
mdehoon e71f6ba
Update Misc/NEWS.d/next/Windows/2026-04-21-16-07-11.gh-issue-140146.T…
mdehoon 475b737
Update Lib/test/test_tkinter/test_tkinter_pipe.py
mdehoon ab8a136
Update Lib/test/test_tkinter/test_tkinter_pipe.py
mdehoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # test_tkinter_pipe.py | ||
| import unittest | ||
| import subprocess | ||
| import sys | ||
| from test import support | ||
|
|
||
|
|
||
| @unittest.skipUnless(support.has_subprocess_support, "test requires subprocess") | ||
| class TkinterPipeTest(unittest.TestCase): | ||
|
|
||
| def test_tkinter_pipe_buffered(self): | ||
| args = [sys.executable, "-i"] | ||
| proc = subprocess.Popen(args, | ||
| stdin=subprocess.PIPE, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE) | ||
| proc.stdin.write(b"import tkinter\n") | ||
| proc.stdin.write(b"interpreter = tkinter.Tcl()\n") | ||
| proc.stdin.write(b"print('hello')\n") | ||
| proc.stdin.write(b"print('goodbye')\n") | ||
| proc.stdin.write(b"quit()\n") | ||
| stdout, stderr = proc.communicate(timeout=support.SHORT_TIMEOUT) | ||
| stdout = stdout.decode() | ||
| self.assertEqual(stdout.split(), ['hello', 'goodbye']) | ||
|
|
||
| def test_tkinter_pipe_unbuffered(self): | ||
| args = [sys.executable, "-i", "-u"] | ||
| proc = subprocess.Popen(args, | ||
| stdin=subprocess.PIPE, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE) | ||
| proc.stdin.write(b"import tkinter\n") | ||
| proc.stdin.write(b"interpreter = tkinter.Tcl()\n") | ||
|
|
||
| proc.stdin.write(b"print('hello')\n") | ||
| proc.stdin.flush() | ||
| stdout = proc.stdout.readline() | ||
| stdout = stdout.decode() | ||
| self.assertEqual(stdout.strip(), 'hello') | ||
|
|
||
| proc.stdin.write(b"print('hello again')\n") | ||
| proc.stdin.flush() | ||
| stdout = proc.stdout.readline() | ||
| stdout = stdout.decode() | ||
| self.assertEqual(stdout.strip(), 'hello again') | ||
|
|
||
| proc.stdin.write(b"print('goodbye')\n") | ||
| proc.stdin.write(b"quit()\n") | ||
| stdout, stderr = proc.communicate(timeout=support.SHORT_TIMEOUT) | ||
| stdout = stdout.decode() | ||
| self.assertEqual(stdout.strip(), 'goodbye') | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Windows/2026-04-21-16-07-11.gh-issue-140146.TAcUHA.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Prevent :mod:`tkinter` from hanging on Windows if stdin is redirected to a pipe in an | ||
| interactive session. This is helpful for testing interactive usage of | ||
| tkinter from a script, for example as part of the cpython test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.