gh-140146: Fix for stdin redirection to a pipe with interactive tkinter on Windows#148819
Merged
serhiy-storchaka merged 9 commits intoJun 29, 2026
Merged
Conversation
Member
|
@mdehoon, please resolve conflict. |
Remove errorInCmd as a condition for the while-loop, as #pythongh-139145 has now been merged.
Contributor
Author
Done. |
Adding a breaking arm for FILE_TYPE_DISK (python -i < file), as a disk file is always readable.
…AcUHA.rst Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
If the test fails, let it fail quickly. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
If the test fails, let it fail quickly. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
Jun 29, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM. 👍
Thanks for handling the rebase and the follow-ups.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @mdehoon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-152560 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-152561 is a backport of this pull request to the 3.14 branch. |
|
GH-152562 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 29, 2026
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 29, 2026
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
EventHookin_tkinter.cwill hang on Windows if Python is run with stdin redirected to a pipe. The reason is that on Windows,EventHookchecks for data availability on stdin by calling_kbhit, which reports if a key was hit on the keyboard. With this patch,EventHookfirst checks whether stdin is a console or a pipe, and then calls either_kbhitorPeekNamedPipe, respectively, to establish if input is available on stdin.