Skip to content

gh-146341: Add new video MIME types to mimetypes.py #146342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clin1234 wants to merge 14 commits into
base: main
Choose a base branch
from
+26 −0
Open

gh-146341: Add new video MIME types to mimetypes.py #146342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f78534d
Add new video MIME types to mimetypes.py
clin1234 Mar 23, 2026
64160d7
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 23, 2026
f0cb261
Indent
clin1234 Mar 23, 2026
9da90cc
Formatting
clin1234 Mar 24, 2026
afe8208
Omit comma
clin1234 Mar 24, 2026
6a0ce38
Again...
clin1234 Mar 24, 2026
eb44724
Add name and GH issue in News fragment
clin1234 Apr 1, 2026
5f96e25
Fix syntax errors in mimetypes.py
clin1234 Apr 2, 2026
6f297ed
Format
clin1234 Apr 11, 2026
d6b42ac
Drop list
clin1234 Apr 11, 2026
cf8fd13
CRLF -> LF
clin1234 May 4, 2026
d434c74
Mark in whatsnew
clin1234 Jul 7, 2026
029244f
Correct bink extension
clin1234 Jul 7, 2026
068d60a
Update Doc/whatsnew/3.16.rst to state issue #
clin1234 Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Doc/whatsnew/3.16.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,8 @@ mimetypes
* Valid extensions start with a '.' or are empty for
:meth:`mimetypes.MimeTypes.add_type`.
Undotted extensions now raise a :exc:`ValueError`.
* Add more MIME types.
(Contributed by Charlie Lin in :gh:`146341`.)

shutil
------
Expand Down
11 changes: 11 additions & 0 deletions Lib/mimetypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,8 +681,13 @@ def _default_mime_types():
'.sgml' : 'text/x-sgml',
'.vcf' : 'text/x-vcard',
'.xml' : 'text/xml',
'.3gp' : 'video/3gpp',
'.3g2' : 'video/3gpp2',
Comment on lines +684 to +685

@hugovk hugovk Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have these earlier in the dict:

        '.3gp'    : 'audio/3gpp',
...
        '.3g2'    : 'audio/3gpp2',

So these new video ones overwrite the audio ones.

Should we change it to the video ones, and remove the audio?

@clin1234 clin1234 Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they're both official MIME types: iana.org/assignments/media-types/audio/3gpp and iana.org/assignments/media-types/video/3gpp. The only major difference as far as I can tell is that the former cannot contain any visual data

@clin1234 clin1234 Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, per the official 3GPP TS 26.244 V19.1.0 Specification:

The type "video/3gpp" is valid for all files. It is valid to serve an audio-only file as "video/3gpp".

@clin1234 clin1234 Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And per this RFC: https://www.rfc-editor.org/info/rfc4393/#section-3.2

@clin1234 clin1234 Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, remove the audio

'.m4s' : 'video/iso.segment',
'.lot' : 'video/lottie+json',
'.mkv' : 'video/matroska',
'.mk3d' : 'video/matroska-3d',
'.mj2' : 'video/mj2',
'.mp4' : 'video/mp4',
'.mpeg' : 'video/mpeg',
'.m1v' : 'video/mpeg',
Expand All @@ -692,6 +697,12 @@ def _default_mime_types():
'.ogv' : 'video/ogg',
'.mov' : 'video/quicktime',
'.qt' : 'video/quicktime',
'.pyv' : 'video/vnd.ms-playready.media.pyv',
'.bik' : 'video/vnd.radgamettools.bink',
'.bk2' : 'video/vnd.radgamettools.bink',
'.sswf' : 'video/vnd.sealed.swf',
'.ssw' : 'video/vnd.sealed.swf',
'.yt' : 'video/vnd.youtube.yt',
'.webm' : 'video/webm',
'.avi' : 'video/vnd.avi',
'.m4v' : 'video/x-m4v',
Expand Down
13 changes: 13 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-23-20-14-57.gh-issue-146341.JSTJlL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Add the following MIME types corresponding to file extensions:

``.3gp`` for ``video/3gpp``
``.3g2`` for ``video/3gpp2``
``.m4s`` for ``video/iso.segment``
``.lot`` for ``video/lottie+json``
``.mj2`` for ``video/mj2``
``.pyv`` for ``video/vnd.ms-playready.media.pyv``
``.blk`` and ``.bk2`` for ``video/vnd.radgamettools.bink``
``.sswf`` and ``.ssw`` for ``video/vnd.sealed.swf``
``.yt`` for ``video/vnd.youtube.yt``

(Contributed by Charlie Lin in :gh:`146342`.)
Loading