gh-146341: Add new video MIME types to mimetypes.py#146342
Conversation
|
Please also like in the other PRs have a look on the checks and declare why failures are unrelated or fix them if not |
| - ``.pyv`` for ``video/vnd.ms-playready.media.pyv`` | ||
| - ``.blk`` and ``.bk2`` for ``video/vnd.radgamettools.bink`` | ||
| - ``.sswf`` and ``.ssw`` for ``video/vnd.sealed.swf`` | ||
| - ``.yt`` for ``video/vnd.youtube.yt`` |
There was a problem hiding this comment.
Same as in other PR, maybe add your name here and please add 3.15 release notes and maybe combine the PRs
benediktjohannes
left a comment
benediktjohannes
left a comment
There was a problem hiding this comment.
Otherwise from short overview LGTM! Thank You for your effort!
|
Will this be merged in before beta1, and can this still be merged in during the beta releases? |
Documentation build overview
272 files changed ·
|
|
You have conflicts, please fix them. |
|
@benediktjohannes @hugovk @StanFromIreland, mind reviewing this PR again? |
| John Franey | ||
| in :gh:`144217`, :gh:`145720`, :gh:`140937`, :gh:`139959`, :gh:`145698`, | ||
| :gh:`145718`, :gh:`145918`, and :gh:`144213`.) | ||
| :gh:`145718`, :gh:`146342`, :gh:`145918`, and :gh:`144213`.) |
There was a problem hiding this comment.
The 3.15 feature freeze has passed, please update for 3.16.
| '.3gp' : 'video/3gpp', | ||
| '.3g2' : 'video/3gpp2', |
There was a problem hiding this comment.
We already have these earlier in the dict:
'.3gp' : 'audio/3gpp',
...
'.3g2' : 'audio/3gpp2',So these new video ones overwrite the audio ones.
Should we change it to the video ones, and remove the audio?
There was a problem hiding this comment.
Well, they're both official MIME types: iana.org/assignments/media-types/audio/3gpp and iana.org/assignments/media-types/video/3gpp. The only major difference as far as I can tell is that the former cannot contain any visual data
There was a problem hiding this comment.
Interestingly, per the official 3GPP TS 26.244 V19.1.0 Specification:
The type "video/3gpp" is valid for all files. It is valid to serve an audio-only file as "video/3gpp".
There was a problem hiding this comment.
And per this RFC: https://www.rfc-editor.org/info/rfc4393/#section-3.2
There was a problem hiding this comment.
So, remove the audio
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
4 participants
videoMIME types with defined file extensions #146341