Skip to content

Add 'strace' sub command for generated test reproduction scripts #22529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derickr wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

Add 'strace' sub command for generated test reproduction scripts #22529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions run-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2769,6 +2769,9 @@ function run_test(string $php, $file, array $env): string
"valgrind")
USE_ZEND_ALLOC=0 valgrind $2 {$orig_cmd}
;;
"strace")
strace -o /tmp/strace -tt -ff $2 {$orig_cmd}

@TimWolla TimWolla Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should write to hardcoded filenames on the file system - and perhaps not add opinionated options either. The -o /tmp/strace can be provided as a parameter.

Perhaps it might make sense to adjust all the cases as follows:

Suggested change
strace -o /tmp/strace -tt -ff $2 {$orig_cmd}
shift
strace "$@" {$orig_cmd}

This should then cleanly enable tests/test.sh strace -tt -ff -o /tmp/strace

@derickr derickr Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make a reasonable argument for not having -o /tmp/strace, but having to make people remember the other arguments seems annoying. In that case, I would just keep my own patch and not bother with this.

;;
"rr")
rr record $2 {$orig_cmd}
;;
Expand Down
Loading