Add 'strace' sub command for generated test reproduction scripts#22529
Open
derickr wants to merge 1 commit into
Open
Add 'strace' sub command for generated test reproduction scripts#22529derickr wants to merge 1 commit into
derickr wants to merge 1 commit into
Conversation
arnaud-lb
approved these changes
Jun 30, 2026
TimWolla
reviewed
Jun 30, 2026
| USE_ZEND_ALLOC=0 valgrind $2 {$orig_cmd} | ||
| ;; | ||
| "strace") | ||
| strace -o /tmp/strace -tt -ff $2 {$orig_cmd} |
Member
There was a problem hiding this comment.
I don't think we should write to hardcoded filenames on the file system - and perhaps not add opinionated options either. The -o /tmp/strace can be provided as a parameter.
Perhaps it might make sense to adjust all the cases as follows:
Suggested change
| strace -o /tmp/strace -tt -ff $2 {$orig_cmd} | |
| shift | |
| strace "$@" {$orig_cmd} |
This should then cleanly enable tests/test.sh strace -tt -ff -o /tmp/strace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
straceto the options for running the reproducing.shfiles that the test runner creates when a test fails. This is useful in case the test itself starts other scripts, and/or does IO between them or at all.I have had this in Xdebug's variant for some time now, and it would be nice not to maintain my patch for this specific item.