[SPIR-V] Add descriptor heap -fvk-resource-heap-stride / -fvk-sampler-heap-stride CLI flags#8519
Open
jzakharovnv wants to merge 11 commits into
Open
[SPIR-V] Add descriptor heap -fvk-resource-heap-stride / -fvk-sampler-heap-stride CLI flags#8519jzakharovnv wants to merge 11 commits into
jzakharovnv wants to merge 11 commits into
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
from
June 4, 2026 21:58
190990b to
7429afb
Compare
Building off of microsoft#8281, this commit adds a native lowering via SPV_EXT_descriptor_heap and SPV_KHR_untyped_pointers. ResourceDescriptorHeap and SamplerDescriptorHeap are lowered to untyped variables decorated with ResourceHeapEXT and SamplerHeapEXT. Each heap access emits OpUntypedAccessChainKHR into a runtime array of the appropriate descriptor type. Buffer-like resources (StructuredBuffer, ByteAddressBuffer, ConstantBuffer, TextureBuffer) use OpTypeBufferEXT and OpBufferPointerEXT; image and sampler resources use OpLoad. Interlocked operations on RWTexture use OpUntypedImageTexelPointerEXT. Requires -fspv-target-env=vulkan1.3. Assisted-by: Claude.
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
2 times, most recently
from
June 4, 2026 22:59
1e2a278 to
5e7b928
Compare
Collaborator
Author
|
@microsoft-github-policy-service agree company="NVIDIA" |
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
from
June 29, 2026 21:45
5e7b928 to
9c5badc
Compare
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
from
July 6, 2026 20:08
9c5badc to
ff7bb88
Compare
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
2 times, most recently
from
July 15, 2026 22:16
d2c47bb to
9f55ccb
Compare
This was referenced Jul 17, 2026
dnovillo
suggested changes
Jul 17, 2026
| can be overridden, in increasing order of precedence: | ||
|
|
||
| - ``[[vk::resource_heap_stride_constant_id(id)]]`` and | ||
| ``[[vk::sampler_heap_stride_constant_id(id)]]`` on a ``uint`` global emit the |
Collaborator
There was a problem hiding this comment.
These spec constant attributes are actually in #8520, right? Maybe move them there? This way, this PR just handles the flags.
Collaborator
Author
There was a problem hiding this comment.
Yes, this was a bit clumsy on my part. Will fix the documentation to remove mention of (now dropped feature) stride spec const attributes.
| !handleHeapStride(Args, OPT_fvk_sampler_heap_stride, | ||
| &opts.SpirvOptions.samplerHeapStride, | ||
| "-fvk-sampler-heap-stride", errors)) { | ||
| return 1; |
Collaborator
There was a problem hiding this comment.
If both flags are wrong, this will short-circuit and only give a single error message. Could you make both calls always happen and return the aggregate? Something like this:
bool ok = handleHeapStride(...resource...);
ok &= handleHeapStride(...sampler...);
if (!ok) return 1;
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
2 times, most recently
from
July 17, 2026 22:26
5925cdb to
6bc5a9e
Compare
Extends the SPV_EXT_descriptor_heap native heap lowering to cover RaytracingAccelerationStructure resources loaded from ResourceDescriptorHeap. Acceleration structure descriptors are accessed via OpUntypedAccessChainKHR into a runtime array of OpTypeAccelerationStructureKHR, consistent with the image and sampler paths added in the previous commit.
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
from
July 23, 2026 19:35
6bc5a9e to
c69d8a0
Compare
dnovillo
approved these changes
Jul 24, 2026
dnovillo
left a comment
dnovillo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fixes. LGTM now.
… CLI flags [SPIR-V] Fix getDescriptorHeapRuntimeArrayType signature mismatch
jzakharovnv
force-pushed
the
pr3-cli-stride-flags
branch
from
July 24, 2026 17:15
fcc9b25 to
2feca89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of #8518, this PR adds two new command-line flags that override the ArrayStride of the descriptor heap runtime arrays emitted by -fspv-use-descriptor-heap. It is part 3/4 in a series.
-fvk-resource-heap-stride and -fvk-sampler-heap-stride sets the stride for ResourceDescriptorHeap SamplerDescriptorHeap arrays respectively. N and M must be a power of two in [8, 256]. When set, the CLI value takes the highest precedence.
Assisted by an AI agent.
@dnovillo