[SPIR-V] Add descriptor heap RaytracingAccelerationStructure support#8518
Open
jzakharovnv wants to merge 6 commits into
Open
[SPIR-V] Add descriptor heap RaytracingAccelerationStructure support#8518jzakharovnv wants to merge 6 commits into
jzakharovnv wants to merge 6 commits into
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jzakharovnv
force-pushed
the
pr2-raytracing-accel-struct
branch
from
June 4, 2026 21:58
b7b19c0 to
d77c9f7
Compare
Building off of microsoft#8281, this commit adds a native lowering via SPV_EXT_descriptor_heap and SPV_KHR_untyped_pointers. ResourceDescriptorHeap and SamplerDescriptorHeap are lowered to untyped variables decorated with ResourceHeapEXT and SamplerHeapEXT. Each heap access emits OpUntypedAccessChainKHR into a runtime array of the appropriate descriptor type. Buffer-like resources (StructuredBuffer, ByteAddressBuffer, ConstantBuffer, TextureBuffer) use OpTypeBufferEXT and OpBufferPointerEXT; image and sampler resources use OpLoad. Interlocked operations on RWTexture use OpUntypedImageTexelPointerEXT. Requires -fspv-target-env=vulkan1.3. Assisted-by: Claude.
jzakharovnv
force-pushed
the
pr2-raytracing-accel-struct
branch
2 times, most recently
from
June 4, 2026 22:59
d899b05 to
b12b9ea
Compare
Collaborator
Author
|
@microsoft-github-policy-service agree company="NVIDIA" |
jzakharovnv
force-pushed
the
pr2-raytracing-accel-struct
branch
from
July 14, 2026 19:46
b12b9ea to
23eca97
Compare
dnovillo
suggested changes
Jul 17, 2026
| return true; | ||
| } | ||
|
|
||
| if (isRaytracingAccelerationStructure(decl->getType())) { |
Collaborator
There was a problem hiding this comment.
Since acceleration structures are distinct from image and buffers, do they still fit in max(sizeof(image), sizeof(buffer))? If not, the stride will be too small and heap indexing will land in the wrong spot.
Maybe we need to incorporate acceleration structures when computing the default stride if RT is used?
| @@ -0,0 +1,42 @@ | |||
| // RUN: %dxc -T lib_6_6 -fspv-use-descriptor-heap -fspv-target-env=vulkan1.3 -fvk-resource-heap-stride 64 -fvk-sampler-heap-stride 32 -fspv-extension=SPV_KHR_ray_tracing -fspv-extension=SPV_EXT_descriptor_heap -fspv-extension=SPV_KHR_untyped_pointers -spirv %s | FileCheck %s | |||
Collaborator
Extends the SPV_EXT_descriptor_heap native heap lowering to cover RaytracingAccelerationStructure resources loaded from ResourceDescriptorHeap. Acceleration structure descriptors are accessed via OpUntypedAccessChainKHR into a runtime array of OpTypeAccelerationStructureKHR, consistent with the image and sampler paths added in the previous commit.
jzakharovnv
force-pushed
the
pr2-raytracing-accel-struct
branch
from
July 17, 2026 21:24
23eca97 to
7455a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of #8517, this PR extends the SPV_EXT_descriptor_heap native heap lowering to cover RaytracingAccelerationStructure resources loaded from ResourceDescriptorHeap. It is part 2/4 in a series.
Acceleration structure descriptors are accessed via OpUntypedAccessChainKHR into a runtime array of OpTypeAccelerationStructureKHR, consistent with the image and sampler paths added in the previous commit.
Assisted by an AI agent
@dnovillo