Skip to content

HTML API: Fix incorrect test assertion #12367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 2 commits into from
Closed

HTML API: Fix incorrect test assertion #12367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
568368c
Fix incorrect test
sirreal Jun 30, 2026
7fe1822
Add another tricky assertion
sirreal Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/phpunit/tests/html-api/wpHtmlTagProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ public static function data_has_self_closing_flag() {
'Self-closing flag after attribute' => array( '<div id=test />', true ),
'Slash inside unquoted attribute value' => array( '<div id=test/>', false ),
'Slash only unquoted attribute value' => array( '<div attr=/>', false ),
'Attribute "=" with value ""' => array( '<div =/>', false ),
'Attribute "=" with value ""' => array( '<div =/>', true ),

@dmsnell dmsnell Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mismatched my expectation.

<div =/> has self-closing flag
<div ==/> does not have self-closing flag

@sirreal sirreal Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this test failure: #12319 (comment).

I missed updating the assertion when I fixed the test name in f685e06.

The test name and this version of the assertion are correct.

'Attribute "=" with value "/"' => array( '<div ==/>', false ),
'Self-closing flag after quoted attribute' => array( '<div id="test"/>', true ),
'Self-closing flag after boolean attribute' => array( '<div enabled/>', true ),
'Ignored "/" and whitespace' => array( '<div / >', false ),
Expand Down
Loading