HTML API: Fix incorrect test assertion#12367
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| 'Slash inside unquoted attribute value' => array( '<div id=test/>', false ), | ||
| 'Slash only unquoted attribute value' => array( '<div attr=/>', false ), | ||
| 'Attribute "=" with value ""' => array( '<div =/>', false ), | ||
| 'Attribute "=" with value ""' => array( '<div =/>', true ), |
There was a problem hiding this comment.
this mismatched my expectation.
<div =/> has self-closing flag
<div ==/> does not have self-closing flag
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
could add another test as per my comment, but this is good to ship and clear up the tests
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| 'Slash inside unquoted attribute value' => array( '<div id=test/>', false ), | ||
| 'Slash only unquoted attribute value' => array( '<div attr=/>', false ), | ||
| 'Attribute "=" with value ""' => array( '<div =/>', false ), | ||
| 'Attribute "=" with value ""' => array( '<div =/>', true ), |
There was a problem hiding this comment.
I noticed this test failure: #12319 (comment).
I missed updating the assertion when I fixed the test name in f685e06.
The test name and this version of the assertion are correct.
[62595] introduced a test assertion for incorrect behavior. Correct the assertion and add another case. Developed in #12367. Props dmsnell. See #65372. Follow-up to [62595]. git-svn-id: https://develop.svn.wordpress.org/trunk@62598 602fd350-edb4-49c9-b593-d223f7449a82
|
Merged in r62598. |
[62595] introduced a test assertion for incorrect behavior. Correct the assertion and add another case. Developed in WordPress/wordpress-develop#12367. Props dmsnell. See #65372. Follow-up to [62595]. Built from https://develop.svn.wordpress.org/trunk@62598 git-svn-id: http://core.svn.wordpress.org/trunk@61878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
[62595] introduced a test assertion for incorrect behavior. Correct the assertion and add another case. Developed in WordPress#12367. Props dmsnell. See #65372. Follow-up to [62595]. git-svn-id: https://develop.svn.wordpress.org/trunk@62598 602fd350-edb4-49c9-b593-d223f7449a82
[62595] introduced a test assertion for incorrect behavior. Correct the assertion and add another case. Developed in WordPress#12367. Props dmsnell. See #65372. Follow-up to [62595]. git-svn-id: https://develop.svn.wordpress.org/trunk@62598 602fd350-edb4-49c9-b593-d223f7449a82
2 participants
r62595 introduced an test code that asserts the wrong behavior. Fix it.
This fixed a test that is currently failing on trunk.
Trac ticket: https://core.trac.wordpress.org/ticket/65372
Follow-up to r62595.
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.