Skip to content

Remove deprecated 1P dev mode#8017

Open
isaacroldan wants to merge 1 commit into
mainfrom
remove-shopify-cli-1p-dev
Open

Remove deprecated 1P dev mode#8017
isaacroldan wants to merge 1 commit into
mainfrom
remove-shopify-cli-1p-dev

Conversation

@isaacroldan

Copy link
Copy Markdown
Contributor

Summary:

  • Remove SHOPIFY_CLI_1P_DEV and the firstPartyDev helper.
  • Drop employee auth/header behavior, 1P Partners defaulting, and local dev console preview switching.
  • Reauth cached employee-scoped sessions and keep app dev on the standard Admin preview/dev-store flow.

Validation:

  • pnpm vitest run packages/cli-kit/src/private/node/api/headers.test.ts packages/cli-kit/src/private/node/session/validate.test.ts packages/app/src/cli/services/dev/fetch.test.ts packages/app/src/cli/services/dev/select-store.test.ts packages/app/src/cli/services/dev/processes/setup-dev-processes.test.ts packages/app/src/cli/services/dev/processes/dev-session/dev-session-process.test.ts
  • pnpm --filter cli-kit type-check
  • pnpm --filter app type-check
  • pnpm --filter cli-kit lint
  • pnpm --filter app lint

Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan requested a review from a team as a code owner July 7, 2026 08:23
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant