Add xtl::select overload for complex values.#293
Merged
Conversation
xtl::select is constrained to scalar types, so xt::where
(xt::detail::conditional_ternary, which calls xtl::select on its scalar
path) does not compile for complex operands, e.g.:
xt::xarray<std::complex<double>> r = xt::where(cond, a, b);
xoperation.hpp:136:24: error: no matching function for call to 'select'
Add an overload in xcomplex.hpp covering std::complex and xtl::xcomplex,
where at least one of the value arguments is complex and the other may be
a scalar. Mirrors how xoptional.hpp hosts the select overload for its own
types.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Implements
xtl::selectfor complex operands, e.g. for downstream use:Code implemented with AI assistance (claude code). PR is human-made.