feat: replace hand-written URL builders with generated ones#529
Open
gjtorikian wants to merge 1 commit into
Open
feat: replace hand-written URL builders with generated ones#529gjtorikian wants to merge 1 commit into
gjtorikian wants to merge 1 commit into
Conversation
…ones The Ruby emitter now generates url-builder methods (regenerated from oagen-emitters) with an optional per-call client_id override that falls back to the client's configured value. Delete the hand-maintained fence copies they replace: - UserManagement#get_authorization_url (H09) and #get_logout_url - SSO#get_authorization_url (H14) The generated builders serialize provider_scopes (CSV) and provider_query_params (JSON) like the deleted hand-written code. Behavior change: a missing client_id / provider is no longer validated client-side — the URL simply omits client_id, matching the Python SDK. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Contributor
Greptile SummaryReplaces hand-written authorization and logout URL construction with generated builders and adds generated API surface updates.
Confidence Score: 3/5The PR is not yet safe to merge because explicit null updates are discarded and the generated authorization URL RBIs reject valid runtime calls. The shared HTTP serializer compacts request bodies after sentinel-backed fields are added, defeating the new explicit-null contract, while both new authorization URL declarations require keywords that their runtime implementations default. Files Needing Attention: lib/workos/base_client.rb, lib/workos/user_management.rb, rbi/workos/user_management.rbi, rbi/workos/sso.rbi Important Files Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserManagement#get_authorization_url(H09),UserManagement#get_logout_url, andSSO#get_authorization_url(H14).client_idoverride that falls back to the client's configured value.provider_scopesis joined as CSV andprovider_query_paramsis encoded as JSON, matching the deleted hand-written code.client_id/provideris no longer validated client-side — the URL simply omitsclient_id, matching the Python SDK.WorkOS::OMITsentinel for nullable optional parameters (distinguishes an omitted argument from an explicitnil) and updates the Sorbet RBIs and AuthKit helper tests accordingly.🤖 Generated with Claude Code