Skip to content

Improve execution of Take(Chunked) for nested types#8662

Draft
robert3005 wants to merge 1 commit into
developfrom
rk/buildertakefixes
Draft

Improve execution of Take(Chunked) for nested types#8662
robert3005 wants to merge 1 commit into
developfrom
rk/buildertakefixes

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This pr does a bunch of things to improve behaviour of Take(Chunked(FSL)).

  1. Improve the Take(Chunked) algorithm itself using some of the new bit iteration
    methods added recently

  2. Make sure that builder appends always route through append_to_builder

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq

codspeed-hq Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.66%

⚡ 8 improved benchmarks
❌ 1 regressed benchmark
✅ 1598 untouched benchmarks
🆕 15 new benchmarks
⏩ 42 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation slice_empty_vortex 310.3 ns 368.6 ns -15.83%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%
Simulation rebuild_naive 105.8 µs 91.6 µs +15.41%
Simulation chunked_varbinview_into_canonical[(100, 100)] 307 µs 272.1 µs +12.83%
Simulation encode_varbin[(1000, 8)] 161.2 µs 144.3 µs +11.74%
Simulation encode_varbin[(1000, 4)] 159.4 µs 142.8 µs +11.66%
Simulation encode_varbin[(1000, 32)] 164.9 µs 149 µs +10.68%
🆕 Simulation take_chunked_f32_canonical_shuffled[10000] N/A 2.7 ms N/A
🆕 Simulation take_chunked_f32_canonical_shuffled[100000] N/A 14.1 ms N/A
🆕 Simulation take_chunked_f32_canonical_shuffled[1000000] N/A 133.8 ms N/A
🆕 Simulation take_chunked_f32_to_builder_shuffled[10000] N/A 2.7 ms N/A
🆕 Simulation take_chunked_f32_to_builder_shuffled[100000] N/A 14.7 ms N/A
🆕 Simulation take_chunked_f32_to_builder_shuffled[1000000] N/A 137.6 ms N/A
🆕 Simulation take_chunked_f32_to_builder_sorted[10000] N/A 2.3 ms N/A
🆕 Simulation take_chunked_f32_to_builder_sorted[100000] N/A 14.5 ms N/A
🆕 Simulation take_chunked_f32_to_builder_sorted[1000000] N/A 129.3 ms N/A
🆕 Simulation take_chunked_of_fsl_to_builder_shuffled[32768] N/A 108.4 ms N/A
🆕 Simulation take_chunked_of_fsl_to_builder_shuffled[4096] N/A 13.6 ms N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/buildertakefixes (0c8d2ea) with develop (a6e3d3e)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant