fix(client): return undefined for missing env values#507
Closed
fengmk2 wants to merge 1 commit into
Closed
Conversation
fengmk2
force-pushed
the
fix/get-env-undefined
branch
from
de6e445 to
1b1be41
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
fengmk2
force-pushed
the
fix/get-env-undefined
branch
from
1b1be41 to
e7ddb97
Compare
Member
|
Ah sorry I didn't see your fix before merging mine. 😄 They are essentially the same. I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Vite reads
NODE_ENVthrough@voidzero-dev/vite-task-clientwhen it runs inside the task runner. The native addon exposed a missing RustOption<String>as JavaScriptnull, despite the client contract promisingundefined. Assigning that result toprocess.env.NODE_ENVcoerced it to the string"null", causing production builds to expose developmentimport.meta.envflags.Related to voidzero-dev/vite-plus#2047.
Changes
undefinedfor missing environment variables at the N-API boundary.NODE_ENV.