Skip to content

fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericallam wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce9657d
fix(webapp): keep the rest of a batch when one run or span has un-ing…
ericallam Jul 23, 2026
f881587
chore(webapp): rename batch row-isolation metric and emit run-replica…
ericallam Jul 24, 2026
cdd4033
refactor(webapp): share JSON-parse recovery and keep poison rows with…
ericallam Jul 24, 2026
4a32ee1
feat(webapp): cap row-isolation recovery cost against a poison flood
ericallam Jul 24, 2026
fc94129
fix(webapp): only count a dropped batch when nothing landed, and asse…
ericallam Jul 24, 2026
c5f1734
test(webapp): sample benchmark ELU as a per-window delta and build po…
ericallam Jul 24, 2026
52a5cba
fix(webapp,clickhouse): stop one un-ingestable JSON row dropping its …
ericallam Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/fix-runs-list-batch-drop-on-unparseable-json.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Fixed a rare case where a single run or span carrying data that could not be ingested would make other runs or trace events in the same batch go missing from the runs list, traces, and logs. Now the rest of the batch is always kept: an affected run still appears with its status (only its un-ingestable output is dropped), and an affected trace event or payload is skipped instead of taking down everything around it.
1 change: 1 addition & 0 deletions apps/webapp/app/env.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,6 +1672,7 @@ const EnvironmentSchema = z
RUN_REPLICATION_MAX_FLUSH_CONCURRENCY: z.coerce.number().int().default(2),
RUN_REPLICATION_FLUSH_INTERVAL_MS: z.coerce.number().int().default(1000),
RUN_REPLICATION_FLUSH_BATCH_SIZE: z.coerce.number().int().default(100),
RUN_REPLICATION_MAX_POISON_STRIPS_PER_BATCH: z.coerce.number().int().default(1),
RUN_REPLICATION_LEADER_LOCK_TIMEOUT_MS: z.coerce.number().int().default(30_000),
RUN_REPLICATION_LEADER_LOCK_EXTEND_INTERVAL_MS: z.coerce.number().int().default(10_000),
RUN_REPLICATION_ACK_INTERVAL_SECONDS: z.coerce.number().int().default(10),
Expand Down
1 change: 1 addition & 0 deletions apps/webapp/app/services/runsReplicationInstance.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ function initializeRunsReplicationInstance() {
maxFlushConcurrency: env.RUN_REPLICATION_MAX_FLUSH_CONCURRENCY,
flushIntervalMs: env.RUN_REPLICATION_FLUSH_INTERVAL_MS,
flushBatchSize: env.RUN_REPLICATION_FLUSH_BATCH_SIZE,
maxPoisonStripsPerBatch: env.RUN_REPLICATION_MAX_POISON_STRIPS_PER_BATCH,
leaderLockTimeoutMs: env.RUN_REPLICATION_LEADER_LOCK_TIMEOUT_MS,
leaderLockExtendIntervalMs: env.RUN_REPLICATION_LEADER_LOCK_EXTEND_INTERVAL_MS,
leaderLockAcquireAdditionalTimeMs: env.RUN_REPLICATION_LEADER_LOCK_ADDITIONAL_TIME_MS,
Expand Down
Loading
Loading