fix(webapp): accept all valid run and batch IDs in dashboard filters#4152
Merged
Conversation
The Run ID and Batch ID filter inputs on the runs list, batches list, and logs view hard-coded the exact friendly-id lengths. Run and batch IDs in the current format are two characters longer, so they were rejected with a "wrong length" error and the Apply button stayed disabled, making it impossible to filter by a recently created run or batch ID from the UI. These filters now validate IDs with the shared id-shape classifier instead of hard-coded lengths, so they accept every valid ID and will not drift if the format changes again. The waitpoint ID filter gets the same fix pre-emptively.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the fix, but it misses required template sections like Closes #issue, checklist, testing steps, changelog, and screenshots. |
Add the missing template sections: Closes #issue, checklist items, testing steps, a short changelog, and screenshots or a note that none are needed. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly matches the main change: relaxing Run and Batch ID validation in dashboard filters. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/ksuid-id-filter-validation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/webapp/app/components/runs/v3/RunFilters.tsx (1)
1772-1775: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate
validateBatchIdlogic across files.This function is byte-for-byte identical to
validateBatchIdinBatchFilters.tsx(lines 229-232). Since the PR's stated goal is reducing "the risk of future drift if the ID format changes again," consolidating this into a single shared helper (e.g., avalidateFriendlyId(prefix, label)utility) would better serve that goal than duplicating the sameisClassifiablecall in two places.♻️ Suggested shared helper
function makeIdValidator(prefix: string, label: string) { return (value: string): string | undefined => { if (!value.startsWith(prefix)) return `${label} start with '${prefix}'`; if (!isClassifiable(value)) return `That doesn't look like a valid ${label.toLowerCase()}`; }; } const validateRunId = makeIdValidator("run_", "Run IDs"); const validateBatchId = makeIdValidator("batch_", "Batch IDs");
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 16864ad6-86b6-4bf6-b51c-0f2f87639fd7
📒 Files selected for processing (5)
.server-changes/fix-ksuid-id-filters.mdapps/webapp/app/components/logs/LogsRunIdFilter.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never import from@trigger.dev/sdk/v3or use deprecatedclient.defineJob.
In code that imports@trigger.dev/core, use subpath imports only and never import from the package root.
Files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
apps/webapp/**/*.tsx
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.tsx: Only useuseCallbackanduseMemofor context provider values, expensive derived data used as dependencies, or stable refs required by a dependency array; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals through comparisons.
Files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
🧠 Learnings (18)
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/fix-ksuid-id-filters.md
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-03-22T13:32:43.005Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/metrics/OperationsFilter.tsx:85-110
Timestamp: 2026-03-22T13:32:43.005Z
Learning: In triggerdotdev/trigger.dev, the shared `FilterMenuProvider` (from `~/components/runs/v3/SharedFilters`) manages Ariakit `ComboboxProvider` state internally and exposes the current `search` value and `setSearch` via render props `(search, setSearch) => …`. For filter components (e.g., `OperationsFilter`, `ModelsFilter`, `QueuesFilter`, `ProvidersFilter`), treat the render-prop tuple and their use of `searchValue={search}` and `clearSearchValue={() => setSearch("")}` as the correct wiring. Do not raise a review finding about missing/broken connection between the ComboBox input and the search state—if the component follows this provider/render-prop pattern and the `filtered` `useMemo` dependencies are reactive, the state synchronization is expected to be handled by Ariakit through the provider.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-03-22T13:32:44.229Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/metrics/ProvidersFilter.tsx:74-96
Timestamp: 2026-03-22T13:32:44.229Z
Learning: When reviewing components under `apps/webapp/app/components/runs/v3/`, avoid flagging “broken/unconnected search state” in filters that use `FilterMenuProvider` wrapping Ariakit’s `ComboboxProvider` and expose `(search, setSearch)` (render props). In this intentional pattern, the `searchValue` render-prop value should be treated as reactive (it re-renders on every keystroke), passed into the dropdown child, and used in `useMemo` to filter options. Do not require additional wiring beyond this established render-prop/ComboboxProvider integration.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsx
📚 Learning: 2026-04-16T14:21:15.229Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/components/logs/LogsTaskFilter.tsx:135-163
Timestamp: 2026-04-16T14:21:15.229Z
Learning: When rendering lists of task registry items in apps/webapp (e.g., <SelectItem /> rows) and using `key={item.slug}`, do not flag it as potentially non-unique. In trigger.dev’s `TaskIdentifier` table, the DB constraint `@unique([runtimeEnvironmentId, slug])` guarantees `slug` is unique within a given runtime environment, so `item.slug` is safe as the React key as long as the list is derived from that registry/constraint (and not from a legacy query that could produce duplicate slugs).
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-25T18:21:55.847Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-resend.tsx:0-0
Timestamp: 2026-06-25T18:21:55.847Z
Learning: In the triggerdotdev/trigger.dev Zod 4 migration, avoid importing from the root package `conform-to/zod` in webapp code. It can resolve to the Zod 3 build and may crash at module load under Zod 4. When reviewing TypeScript/TSX files in `apps/webapp`, prefer importing from the Zod 4 subpath `conform-to/zod/v4` for Zod 4-compatible schemas/types.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
📚 Learning: 2026-06-25T18:21:54.729Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/confirm-basic-details.tsx:0-0
Timestamp: 2026-06-25T18:21:54.729Z
Learning: For Remix + TypeScript files that use Conform v1 (conform-to/react) and its getInputProps helper, when you intend to suppress the helper-provided default value for non-checkbox/non-radio inputs (e.g., hidden inputs managed via an explicit value prop), use the Conform v1 option key `value: false`. Do not recommend `defaultValue: false` here, because `defaultValue` is not a valid option key for these input types in Conform v1 typings.
Applied to files:
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsxapps/webapp/app/components/runs/v3/BatchFilters.tsxapps/webapp/app/components/runs/v3/RunFilters.tsxapps/webapp/app/components/logs/LogsRunIdFilter.tsx
🔇 Additional comments (7)
.server-changes/fix-ksuid-id-filters.md (1)
1-7: LGTM!apps/webapp/app/components/runs/v3/BatchFilters.tsx (2)
229-232: Same asvalidateBatchIdinRunFilters.tsx.Identical logic already flagged for consolidation there.
4-4: LGTM!apps/webapp/app/components/runs/v3/RunFilters.tsx (2)
16-16: LGTM!
1717-1720: 🎯 Functional CorrectnessValidation logic checks out.
Cross-checking against
isClassifiable(internalForm(id).length === CUID_LENGTH || KSUID_LENGTH): the old length checks forrun_(25/29 chars) minus the 4-char prefix yield 21/25, matching the presumedCUID_LENGTH/KSUID_LENGTHvalues. This confirms the new check preserves the same acceptance set while decoupling from hard-coded totals.apps/webapp/app/components/logs/LogsRunIdFilter.tsx (1)
3-3: LGTM!Also applies to: 76-78
apps/webapp/app/components/runs/v3/WaitpointTokenFilters.tsx (1)
5-5: 🗄️ Data Integrity & IntegrationNo issue:
internalFormalready strips the first_-delimited prefix generically, sowaitpoint_is handled the same way as the other ID prefixes.> Likely an incorrect or invalid review comment.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace the per-filter isClassifiable checks with a single makeFriendlyIdValidator helper covered by unit tests. isClassifiable only recognizes cuid and ksuid bodies, so it rejected legacy nanoid ids (run_ / batch_ + 21-char body) that the filters previously accepted; the helper accepts all three body lengths (21 nanoid, 25 cuid, 27 ksuid) and is now shared by the run, batch, waitpoint, and schedule filters.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ericallam
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Run ID and Batch ID filters on the runs list, batches list, and logs view rejected valid IDs. The input showed an error and the Apply button stayed disabled, so filtering by an affected run or batch ID from the dashboard was impossible.
The filter validators hard-coded exact friendly-id character lengths. Friendly IDs come in three generations that all still exist in the data (
<prefix>_plus a 21-char nanoid, a 25-char cuid, or a 27-char ksuid), and the hard-coded lengths never covered all three at once.Fix
All the ID filter validators (run, batch, waitpoint, schedule) now share one helper,
makeFriendlyIdValidator(apps/webapp/app/utils/friendlyId.ts), which validates by prefix plus a base62 body of any known generator length (21 / 25 / 27). The cuid and ksuid lengths are sourced from core so the helper tracks any future change to those formats. Unit tests assert it accepts the output of the real id generators and rejects malformed input.Downstream was already unaffected: run/batch route params and URL-applied filters use unconstrained validation, so only the manual filter inputs needed the fix.