feat(webapp): add Abort button to bulk actions list rows#4144
Conversation
The Bulk actions list did not surface any per-row actions, so aborting an in-progress bulk action meant opening a row's inspector to reach its Abort button. This adds an Abort button that appears on row hover (the same pattern as the Test button on the Tasks list) for bulk actions that are still running. The button submits to the existing abort action, so it does exactly what the inspector's Abort button does. It respects write:runs and is shown disabled with a tooltip when the user lacks permission.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | It covers the summary but misses the required template sections like Closes #issue, checklist, testing, changelog, and screenshots. |
Fill in the full template: add Closes #issue, checklist items, testing steps, changelog, and screenshots or mark them N/A. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly names the main change: adding an Abort button to bulk action list rows. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
feature/tri-11607-add-row-action-menu-ellipsis-with-abort-to-the-bulk-actions
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Aborting a bulk action from the list row button or the inspector now opens a confirmation dialog (matching the "Cancel this run?" flow) instead of firing immediately, so it's harder to abort by accident. Both entry points share a new AbortBulkActionDialog that posts to the existing abort action.
Summary
The Bulk actions list didn't surface any per-row actions, so aborting an in-progress bulk action meant clicking into a row to open its inspector and using the Abort button there. This adds an Abort button that appears on row hover (the same pattern as the Test button on the Tasks list) for bulk actions that are still running.
The button submits to the existing abort action on the bulk action detail route, so it does exactly what the inspector's Abort button does, no duplicated service call. It's gated on
write:runs(disabled with a tooltip when the user lacks permission) and only renders while a bulk action is still in progress.