Skip to content

fix: deploy the dashboard agent one environment at a time#4133

Merged
ericallam merged 2 commits into
mainfrom
fix/tri-11573-dashboard-agent-deploy-serialize
Jul 3, 2026
Merged

fix: deploy the dashboard agent one environment at a time#4133
ericallam merged 2 commits into
mainfrom
fix/tri-11573-dashboard-agent-deploy-serialize

Conversation

@ericallam

@ericallam ericallam commented Jul 3, 2026

Copy link
Copy Markdown
Member

The dashboard agent deploy runs a matrix leg per environment (staging, prod). Running them in parallel deployed the same Trigger.dev project twice at once, and one leg failed to create the background worker while the other succeeded. max-parallel: 1 runs the legs sequentially so a deploy never races itself.

Also aligns the workflow's Node version to the repo standard (22.23.1, per .nvmrc).

Verified: re-running the staging leg on its own (no parallel prod) deployed cleanly.

Parallel legs deploying the same Trigger.dev project raced: one leg failed to
create the background worker while the other succeeded. Run the matrix with
max-parallel 1 so the environments deploy sequentially.
@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7891790

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam ericallam marked this pull request as ready for review July 3, 2026 09:40
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The dashboard agent deploy workflow now sets max-parallel: 1 on the deploy matrix strategy and updates the Node.js setup step from 20.20.2 to 22.23.1. No other workflow steps or parameters changed.

Changes

File Summary
.github/workflows/dashboard-agent-deploy.yml Added matrix serialization for deploys and updated the Node.js version used by actions/setup-node.

Related Issues: No related issues linked.

Related PRs: No related PRs found.

Suggested Labels: ci, github-actions

Suggested Reviewers: No specific reviewer suggestions available.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description doesn't follow the required template and is missing the issue link, checklist, Testing, Changelog, and Screenshots sections. Fill in the template: add Closes #, complete the checklist, and provide Testing, Changelog, and Screenshots sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and accurately reflects the main change: sequential environment deployments for the dashboard agent.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tri-11573-dashboard-agent-deploy-serialize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

Aligns node-version to 22.23.1 (.nvmrc), matching every other workflow.
@ericallam ericallam merged commit eecb27c into main Jul 3, 2026
27 checks passed
@ericallam ericallam deleted the fix/tri-11573-dashboard-agent-deploy-serialize branch July 3, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants