ci: pin third-party actions to full commit SHAs (matching the existing setup-uv pin)#2249
Open
kobihikri wants to merge 1 commit into
Open
ci: pin third-party actions to full commit SHAs (matching the existing setup-uv pin)#2249kobihikri wants to merge 1 commit into
kobihikri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thank you for Tortoise ORM.
CI supply-chain hardening that matches a practice you already follow. Every workflow already SHA-pins
astral-sh/setup-uv(…08807647… # v8.1.0), but four third-party actions in secret-bearing jobs are still on mutable refs:peaceiris/actions-gh-pages@v3(×2, holdsPERSONAL_TOKENthat pushes totortoise/tortoise.github.io)CodSpeedHQ/action@v3(holdsCODSPEED_TOKEN)pypa/gh-action-pypi-publish@release/v1(a mutable branch, holdspypi_password)This PR pins each to the commit its current ref points at, with a version comment — same style as your setup-uv pin. I stayed on the v3 line for the two
@v3actions (no major-version change) and used the current v1 release for pypi-publish. Dependabot'sgithub-actionsecosystem can bump these going forward.Verified SHAs: peaceiris v3.9.3
373f7f2…, CodSpeed v3.8.176578c2…, pypi-publish v1.14.06733eb7….For transparency: I used AI assistance to spot and draft this; I verified the refs and resolved the SHAs myself.