fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers]#655
Open
tony wants to merge 2 commits into
Open
fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers]#655tony wants to merge 2 commits into
tony wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 51.78% 51.86% +0.08%
==========================================
Files 25 25
Lines 3638 3638
Branches 733 733
==========================================
+ Hits 1884 1887 +3
+ Misses 1448 1445 -3
Partials 306 306 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
0cecae7 to
7bb49f0
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
7bb49f0 to
33e94ab
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
33e94ab to
cb5ebd4
Compare
why: The command_complete() check matched the marker string inside the shell command echo line ($ printf ... echo "__DONE_...") before the command actually executed. On slower systems or CI, this race condition caused the test to capture the pane before seq produced output. what: - Change marker detection to skip lines starting with $ (shell prompt echo) - Marker now only matches when it appears as actual command output Fixes #654
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
cb5ebd4 to
6c451e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_capture_pane_flags[join_wrapped_numbers]where the completion marker was detected in the shell command echo before the command actually executedTest plan
uv run py.test tests/test_pane_capture_pane.py -v— all 19 tests passFixes #654