Bundle 5 dependabot dependency updates#272
Merged
Merged
Conversation
Bumps postgrex 0.22.2 -> 0.22.3, credo 1.7.18 -> 1.7.19, tesla 1.17.0 -> 1.20.0, mongodb_driver 1.6.2 -> 1.6.3, and kafka_ex 0.15.0 -> 1.1.0. kafka_ex 1.0 was a full API rewrite (legacy modules like KafkaEx.Protocol.CreateTopics.TopicRequest and top-level functions like KafkaEx.produce/4, KafkaEx.stream/3, KafkaEx.metadata/1 were removed in favor of KafkaEx.API.*), which broke test/container/kafka_container_test.exs at compile time. Migrated the test to KafkaEx.API.create_topic/produce_one/fetch. The Kafka container implementation itself doesn't depend on kafka_ex (it shells out to kafka-topics.sh), so no lib/ changes were needed. Targets kafka_ex 1.1.0 rather than the 1.0.1 the dependabot PR proposed, since 1.1.0 (released today) fixes a stream auto-commit data-loss bug present in 1.0.1. Supersedes #267, #268, #269, #270, #271.
uniq 0.6.3 added lib/scoped_uuid.ex, which uses a binary pattern construct that fails to compile on Elixir 1.15 (works fine on 1.16+). We only ever call Uniq.UUID.uuid4/0, never Uniq.ScopedUUID, so pinning below the offending release has no functional impact. Verified no security regression: no advisories for uniq in the OSV or GitHub Security Advisories databases at any version, and the only other change between 0.6.2 and 0.6.3 is a cosmetic refactor of an internal compare/2 helper. This was failing identically on main and on all 5 original dependabot PRs before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the 5 open dependabot PRs into one, with kafka_ex's breaking API changes fixed:
kafka_ex 1.0 was a full API rewrite — legacy modules (
KafkaEx.Protocol.CreateTopics.TopicRequest) and top-level functions (KafkaEx.produce/4,KafkaEx.stream/3,KafkaEx.metadata/1) were removed in favor ofKafkaEx.API.*. This broketest/container/kafka_container_test.exsat compile time on #270 (visible in its failing CI checks). Migrated the test toKafkaEx.API.create_topic/3,produce_one/5, andfetch/4.lib/container/kafka_container.exitself doesn't depend on kafka_ex at all (it shells out tokafka-topics.sh), so no library code changed.The other 4 bumps needed no code changes — their existing
mix.exsversion constraints already permitted the new versions; onlymix.lockmoved. kafka_ex's constraint (~> 0.13) needed updating to~> 1.0to allow the major bump.Closes #267
Closes #268
Closes #269
Closes #270
Closes #271
Test plan
mix test(full suite, no exclusions) — 246 tests, 0 failures, including the migrated real-Kafka-container tests against Dockermix credo --strict— no issuesmix format --check-formatted— clean