fix(campaign): isolate proposer selection from test#355
Draft
drewstone wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
compareProposersown three non-empty, pairwise-disjoint partitions: train, selection, and untouched testProposerOptimizationData; finish every optimizer before the first test dispatchholdoutScenariosAPI and rename result fields to reflect what was actually measuredWhy
SkillOpt reused
holdoutScenariosadaptively for edit acceptance, thencompareProposersranked every method on those same rows. That makes the final ranking optimistically biased. The new API makes candidate selection and final testing separate by construction and rejects overlap before any scoring.Compatibility
This is intentionally breaking rather than silently treating selection data as test data. Callers must provide
trainScenarios,selectionScenarios, andtestScenarios;runSkillOptcallers must rename adaptive holdout data toselectionScenarios.Verification
pnpm typecheckpnpm vitest run tests/campaign/compare-proposers.test.ts tests/campaign/skill-opt.test.ts(40 passed)pnpm test(2,942 passed, 2 skipped)pnpm buildpnpm lint(passes with four pre-existing warnings outside this diff)pnpm verify:packagegit merge-tree --write-tree origin/main HEAD