fix: wire blas/ext/base/sany into parent namespace#13196
Closed
Planeshifter wants to merge 1 commit into
Closed
Conversation
Register `sany` in `@stdlib/blas/ext/base/lib/index.js`, add it to the namespace table of contents in `README.md`, and add the import + `Namespace` member to `docs/types/index.d.ts`. Without these entries, the package added in 6e441cc was unreachable via the parent namespace and absent from the TypeScript declarations.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
requested changes
Jun 29, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
We have separate workflows for this, and it needs to be split across multiple commits. Closing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-06-28 17:09 UTC and 2026-06-29 09:22 UTC (285b7819→6e441cc1).Description
This pull request:
@stdlib/blas/ext/base/sanypackage into theblas/ext/baseparent namespace. The package directory landed in6e441ccbut was never registered in the JS namespace index, the TypeScript declarations, or the README table of contents, so it was unreachable viarequire('@stdlib/blas/ext/base'), missing from theNamespacetype, and absent from the namespace docs.Findings (one commit, three additions, all under
lib/node_modules/@stdlib/blas/ext/base/):6e441cc) —sanywas not wired into the namespacelib/index.jsalongside its siblings;require('@stdlib/blas/ext/base').sanyreturnedundefined. Toucheslib/node_modules/@stdlib/blas/ext/base/lib/index.js.591dea2) — Auto-regen pulled indany,dlastIndexOfFalsy, andslastIndexOfFalsybut droppedsany; added the missing import andNamespacemember. Toucheslib/node_modules/@stdlib/blas/ext/base/docs/types/index.d.ts.26d85f8) — TOC regen included the three sibling entries but omitted thesanysignature line and link reference. Toucheslib/node_modules/@stdlib/blas/ext/base/README.md.Related Issues
No.
Questions
No.
Other
24h commit window audited (9 commits,
285b7819..6e441cc1):Validation: Style-guide compliance (
docs/style-guides) and bug-scan reviews were run in parallel; the only surviving high-signal issue was the missingsanywiring, independently identified by two reviewers and verified against the in-tree state ofblas/ext/base/lib/index.js, the namespace TS declarations, and the README TOC. Bot-regenerated REPL data files under@stdlib/repl/*/data/are deliberately not touched here — they should follow from the usual regeneration pass once this lands.Deliberately excluded:
repl.txttrailing-newline diff vs. older siblings (snansum,sapxsum): the most recent peerdany/docs/repl.txtuses the same single-trailing-newline form assany, so this is current convention, not a violation.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was drafted by Claude Code as part of an automated 24-hour follow-up review of
develop. A parallel panel of reviewer agents flagged the missing namespace wiring; the fix and PR body were generated by Claude and are pending human audit (the PR is intentionally left in draft state for a maintainer to promote).@stdlib-js/reviewers
Generated by Claude Code