Skip to content

fix: wire blas/ext/base/sany into parent namespace#13196

Closed
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-06-29
Closed

fix: wire blas/ext/base/sany into parent namespace#13196
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-commit-review-2026-06-29

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-06-28 17:09 UTC and 2026-06-29 09:22 UTC (285b78196e441cc1).

Description

What is the purpose of this pull request?

This pull request:

  • Wires the newly added @stdlib/blas/ext/base/sany package into the blas/ext/base parent namespace. The package directory landed in 6e441cc but was never registered in the JS namespace index, the TypeScript declarations, or the README table of contents, so it was unreachable via require('@stdlib/blas/ext/base'), missing from the Namespace type, and absent from the namespace docs.

Findings (one commit, three additions, all under lib/node_modules/@stdlib/blas/ext/base/):

  • JS namespace registration (6e441cc) — sany was not wired into the namespace lib/index.js alongside its siblings; require('@stdlib/blas/ext/base').sany returned undefined. Touches lib/node_modules/@stdlib/blas/ext/base/lib/index.js.
  • TypeScript declarations (591dea2) — Auto-regen pulled in dany, dlastIndexOfFalsy, and slastIndexOfFalsy but dropped sany; added the missing import and Namespace member. Touches lib/node_modules/@stdlib/blas/ext/base/docs/types/index.d.ts.
  • README table of contents (26d85f8) — TOC regen included the three sibling entries but omitted the sany signature line and link reference. Touches lib/node_modules/@stdlib/blas/ext/base/README.md.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

24h commit window audited (9 commits, 285b7819..6e441cc1):

285b7819  chore: fix JavaScript lint errors
f29ec0b8  docs: add source section header
26d85f80  docs: update namespace table of contents
82e40221  docs: update REPL namespace documentation
591dea2e  feat: update `blas/ext/base` TypeScript declarations
e9f75542  docs: update related packages sections
ce4edb12  docs: add examples
7cdcb0a4  chore: fix JavaScript lint errors
6e441cc1  feat: add `blas/ext/base/sany`

Validation: Style-guide compliance (docs/style-guides) and bug-scan reviews were run in parallel; the only surviving high-signal issue was the missing sany wiring, independently identified by two reviewers and verified against the in-tree state of blas/ext/base/lib/index.js, the namespace TS declarations, and the README TOC. Bot-regenerated REPL data files under @stdlib/repl/*/data/ are deliberately not touched here — they should follow from the usual regeneration pass once this lands.

Deliberately excluded:

  • repl.txt trailing-newline diff vs. older siblings (snansum, sapxsum): the most recent peer dany/docs/repl.txt uses the same single-trailing-newline form as sany, so this is current convention, not a violation.
  • Anything requiring touching code outside the diff window (e.g., REPL CSV/JSON regeneration).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was drafted by Claude Code as part of an automated 24-hour follow-up review of develop. A parallel panel of reviewer agents flagged the missing namespace wiring; the fix and PR body were generated by Claude and are pending human audit (the PR is intentionally left in draft state for a maintainer to promote).


@stdlib-js/reviewers


Generated by Claude Code

Register `sany` in `@stdlib/blas/ext/base/lib/index.js`, add it to the namespace table of contents in `README.md`, and add the import + `Namespace` member to `docs/types/index.d.ts`. Without these entries, the package added in 6e441cc was unreachable via the parent namespace and absent from the TypeScript declarations.
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base $\\color{red}107417/129659$
$\\color{green}+82.85\\%$
$\\color{red}1943/2193$
$\\color{green}+88.60\\%$
$\\color{red}20/1086$
$\\color{green}+1.84\\%$
$\\color{red}107417/129659$
$\\color{green}+82.85\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have separate workflows for this, and it needs to be split across multiple commits. Closing...

@kgryte kgryte closed this Jun 29, 2026
@kgryte kgryte deleted the philipp/fix-commit-review-2026-06-29 branch June 29, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants