Skip to content

chore: fix JavaScript lint errors#13186

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
NotFoundOvO:fix/lint-makie-object-keys
Jun 29, 2026
Merged

chore: fix JavaScript lint errors#13186
kgryte merged 1 commit into
stdlib-js:developfrom
NotFoundOvO:fix/lint-makie-object-keys

Conversation

@NotFoundOvO

@NotFoundOvO NotFoundOvO commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Resolves #13185.

Description

This pull request:

  • Replaces Object.keys with @stdlib/utils/keys in the makie tool, fixing the lint error flagged by the CI.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

The linter was complaining about using Object.keys directly.
Swapped it out for the stdlib equivalent.
@NotFoundOvO NotFoundOvO requested a review from a team June 29, 2026 02:03
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. labels Jun 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Jun 29, 2026
@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #13185) chore: fix JavaScript lint errors Jun 29, 2026
@kgryte kgryte merged commit 7cdcb0a into stdlib-js:develop Jun 29, 2026
106 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants