feat(ske): support audit log configuration#1578
Open
tobias-pfaffelmoser-ske wants to merge 6 commits into
Open
feat(ske): support audit log configuration#1578tobias-pfaffelmoser-ske wants to merge 6 commits into
tobias-pfaffelmoser-ske wants to merge 6 commits into
Conversation
relusc
reviewed
Jul 13, 2026
| "access_idp": "Configure IDP", | ||
| "access_idp_enabled": "Enable IDP integration for the cluster.", | ||
| "access_idp_type": "The IDP type. Possible values: 'stackit'.", | ||
| "audit": "Cluster audit log forwarding configuration. This feature is in private preview. Enabling audit logging is only possible for enabled accounts.", |
There was a problem hiding this comment.
Suggested change
| "audit": "Cluster audit log forwarding configuration. This feature is in private preview. Enabling audit logging is only possible for enabled accounts.", | |
| "audit": "Cluster audit log forwarding configuration.", |
This can be shortened as it is not part of any public documentation, release notes or similar
| } | ||
|
|
||
| // The user explicitly configured `audit = { enabled = false }`. The API does | ||
| // not echo a disabled audit config back, so we keep the configured value to |
There was a problem hiding this comment.
If nothing is configured for a cluster, then the API always echoes audit = {enabled = false} in regions where the feature is available.
There was a problem hiding this comment.
I'm not sure what this means for the code exactly. But we can probably drop the if below. For regions without the feature, we actually want the Otherwise case below as users there shouldn't enable the feature in terraform anyways.
There was a problem hiding this comment.
Makes sense. Simplified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for configuring SKE cluster audit log forwarding via a new optional
auditblock on thestackit_ske_clusterresource (and as a read-only attributeon the data source):
The audit.enabled flag is passed through to the SKE API (ske.Audit) on create/update and mapped back into state on read. This feature is in private preview and can only be enabled for accounts/projects that have been enabled for audit log forwarding to a Telemetry Router.
This also bumps the stackit-sdk-go/services/ske dependency to v1.19.0, which introduces the audit field.
Acceptance tests are intentionally omitted: audit log forwarding is a private-preview feature that requires account/project enablement, which might not be available in the standard CI test project. The change is covered by unit tests (toAuditPayload, mapAudit) and both K8s
createandupdatewere verified manually against a preview-enabled OnDemand QA project.Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)