Skip to content

Refactor: Addressing SecObserve advisories#1232

Merged
NickLarsenNZ merged 3 commits into
stackabletech:mainfrom
Saul-STFC:main
Jun 29, 2026
Merged

Refactor: Addressing SecObserve advisories#1232
NickLarsenNZ merged 3 commits into
stackabletech:mainfrom
Saul-STFC:main

Conversation

@Saul-STFC

@Saul-STFC Saul-STFC commented Jun 26, 2026 •
edited by NickLarsenNZ
Loading

Copy link
Copy Markdown
Contributor

Description

Part of https://github.com/stackabletech/internal-issues/issues/175.

Refactor: Addressing SecObserve advisories

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@Saul-STFC Saul-STFC marked this pull request as draft June 26, 2026 08:41
@Saul-STFC Saul-STFC marked this pull request as ready for review June 26, 2026 08:42
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Jun 26, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Jun 26, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 26, 2026
@NickLarsenNZ NickLarsenNZ enabled auto-merge June 26, 2026 12:30
auto-merge was automatically disabled June 29, 2026 09:29

Head branch was pushed to by a user without write access

@Saul-STFC

Saul-STFC commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the yaml formatting, I didn't have the pre commit installed

NickLarsenNZ
NickLarsenNZ approved these changes Jun 29, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ reopened this Jun 29, 2026
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jun 29, 2026
Merged via the queue into stackabletech:main with commit 046a376 Jun 29, 2026
13 checks passed
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Jun 29, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Saul-STFC Saul-STFC

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Saul-STFC @NickLarsenNZ @lfrancke