feat: Add universal navigation bar#149
Conversation
|
Do you have a screenshot available? Or can it be deployed somewhere? |
If it's not too much to ask I would prefer if you could build it and try it out (to catch things that don't work). For that you would go into the |
Basically the same as in https://hub.stackable.tech/ but with the adjustments mentioned above |
| <div class="universal-nav" role="region" aria-label="Stackable network"> | ||
| <div class="universal-nav__bar"> | ||
| <a class="universal-nav__brand" href="{{{ relativize (versioned "home" page "index.html") }}}" aria-label="Stackable Documentation home"> | ||
| <img class="universal-nav__logo" src="{{{uiRootPath}}}/img/stackable-mark.svg" alt=""> |
There was a problem hiding this comment.
Having this right above the logo of the docs header looks really weird/overloaded. I would remove one of the two (most likely the one from the docs header as this universal nav bar seems to be the way forward).
There was a problem hiding this comment.
Agreed, but would do that as part of another PR to keep the scope about the universal header only.
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Approved based on resolved comments.


This PR adds the universal navigation bar, similar to the one in the HUB, mimicking its design and functionality, but adjusted some minor things compared to the HUB version: