Skip to content

feat: add clientWidth/clientHeight for createElementSize#804

Draft
ylc395 wants to merge 2 commits into
solidjs-community:mainfrom
ylc395:feature/clientWidth-clientHeight
Draft

feat: add clientWidth/clientHeight for createElementSize#804
ylc395 wants to merge 2 commits into
solidjs-community:mainfrom
ylc395:feature/clientWidth-clientHeight

Conversation

@ylc395

@ylc395 ylc395 commented Jul 1, 2025

Copy link
Copy Markdown

add extra clientWidth/clientHeight for createElementSize.

description

If this proposal is acceptable, we can keep on going, otherwise just close PR.

@changeset-bot

changeset-bot Bot commented Jul 1, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 42d3224

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ylc395 ylc395 marked this pull request as draft July 1, 2025 12:33
@ylc395 ylc395 force-pushed the feature/clientWidth-clientHeight branch from ffc6e7e to 0617514 Compare July 1, 2025 12:36
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9f16df0b-db0f-4f6b-a074-d27059831ca8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davedbase

Copy link
Copy Markdown
Member

@ylc395 I'd love to merge this. Can you add a changeset? Also I've migrated your changes to the new 2.0 release we're planning. If I don't hear back I'll close this out though which would be a shame.

@github-actions github-actions Bot mentioned this pull request Jul 4, 2026
@davedbase davedbase added the enhancement New feature or request label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants