-
Notifications
You must be signed in to change notification settings - Fork 195
refactor: send webhooks with the @slack/webhook package #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
322414c
build(deps): use @slack/webhook + p-retry, drop axios
zimeg ff62bc4
test: stub @slack/webhook send() instead of axios
zimeg b212a66
refactor: drop axios from config, let SDK own webhook User-Agent
zimeg f6e2eae
test: webhook techniques via @slack/webhook with p-retry gating
zimeg 074e58f
feat: post webhooks via @slack/webhook with action-side retries
zimeg 12111a6
test: drop trailing blank after removing duplicate metadata test
zimeg f0480df
refactor: delegate webhook retries to @slack/webhook SDK
zimeg 08d6c7a
build(deps): sync lockfile with @slack/webhook retry deps
zimeg 90399da
feat: instrument @slack/webhook requests with the action User-Agent
zimeg 629012b
fix: restore proxy protocol validation in webhook proxies()
zimeg 78332d8
refactor: build webhook clients via config.webhook in post()
zimeg 0a3e445
docs: restore retries() summary and required option param
zimeg c0b1d99
fix: restore non-HTTPS webhook proxy skip in proxies()
zimeg 081de9d
docs: reference both proxy PRs in proxies() JSDoc
zimeg be24575
refactor: return from post() switch cases instead of break
zimeg 76060ba
refactor: return proxy agent directly from proxies()
zimeg f48a437
docs: restore original proxies() summary line
zimeg 174408b
docs: trim Webhook class doc and say package over SDK
zimeg 79632a1
docs: restore original Webhook class summary, keep reference link
zimeg f723656
test: nest webhook stubs under a shared webhook mock
zimeg 9992ffa
test: import @slack/webhook as a namespace
zimeg c613aad
test: order the webhook mock alphabetically after webapi
zimeg bd0ad53
test: restore the missing-webhook guard test for proxies()
zimeg 1f35361
test: restore try/catch success wrapper and two-line retries setup
zimeg 1bf60fd
test: keep the unknown-url-protocol proxy test wording from main
zimeg 27b568c
test: restore original retries test names
zimeg ff5229b
build: depend on published @slack/webhook 7.2.0-rc.1
zimeg 2419dc7
Merge origin/main into webhook-trigger-sdk
zimeg 9b4fd31
test: drive webhook metadata test through webhook inputs
zimeg 4fbd824
test: mirror client retry tests and drop unused p-retry
zimeg ab85bec
test: fix mislabeled client instance in retry tests
zimeg 3cb2eb4
test: fix leading-space rapid retries case for webhook
zimeg f4e747d
test: assert error message propagates on webhook send failures
zimeg dd460ac
test: cover the errors-enabled webhook throw path
zimeg 8d5b655
test: exercise webhook failures with errors input enabled
zimeg 7341171
test: drop messages from the webhook failure assert.fail calls
zimeg 67834be
test: reassert payload and response output on webhook failures
zimeg 39a1599
test: keep the malformed textt payload in the incoming failure test
zimeg 4819c47
test: restore proxies test order and http-skip test name
zimeg fc8f5cc
test: order the https proxy agent test before the no-proxy case
zimeg e26bbfc
test: cover http proxy agent and unknown webhook type paths
zimeg 7631131
test: drop the message from the unknown-type assert.fail
zimeg 7c83ef1
feat: use the @slack/webhook retryPolicies namespace export
zimeg bfa0059
fix: output the whole webhook trigger response
zimeg 6544c23
build: depend on the stable @slack/webhook 7.2.0 release
zimeg 07eb05c
chore: merge w main
zimeg 2edc9cb
build: allow compatible @slack/webhook 7.x releases
zimeg 54258ed
chore: add a patch changeset for the webhook-trigger SDK migration
zimeg 197f045
chore: changeset
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@slack/slack-github-action": patch | ||
| --- | ||
|
|
||
| refactor: send webhooks with the [`@slack/webhook`](https://docs.slack.dev/tools/node-slack-sdk/webhook) package |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡 praise: Thank you
axiosandaxios-retryfor sending with confidence!