fix: defer timeline pointer capture until drag starts so clip child clicks work#148
Merged
Conversation
|
🎉 This PR is included in version 2.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clicking the luma mask badge on a timeline clip no longer detached the mask. Capturing the pointer to the tracks container on every clip pointerdown retargets the derived
clickevent away from clip children, so the badge's click handler never fired.Pointer capture now happens only when a gesture commits: immediately for resize, and at the drag threshold for drags. Plain clicks flow to clip children untouched.
Why it's safe
The interruption handling that introduced the capture is preserved:
pointercanceland the lost-pointerupbuttonscheck are unchanged, and drag/resize (the only states with visible stuck-clip risk) still capture. A lost pointerup during the pending state has no visual side effects and is cleared by the existing cancel paths. All six interruption tests pass unchanged.Verify