ci: remove the post-release Update Apps step#1307
Open
abueide wants to merge 1 commit into
Open
Conversation
Traced its origin back to a local devbox maintenance script (update-apps, meant for a maintainer to manually refresh the example app's lockfile) that got wired into the production release job at some point. As a CI step it never made sense: it runs after the actual npm publish, so it can't gate release correctness, and nothing here commits or pushes the "updated" lockfiles back - the runner is ephemeral, so the whole step is a no-op with no lasting effect except surfacing unrelated curation-block noise (examples/AnalyticsReactNativeExample is a standalone yarn project outside the root workspace, so it isn't covered by any of this session's resolutions fixes) that makes a successful release look broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update-apps) that got wired into the release job at some point - as a CI step it never made sense: it runs after the actual npm publish (can't gate release correctness), and nothing commits/pushes the "updated" lockfiles back (runner is ephemeral, so it's a no-op with no lasting effect).examples/AnalyticsReactNativeExampleis a standalone yarn project outside the root workspace, so it isn't covered by any of the curation-block fixes from ci: switch to ubuntu-latest-large, likely root cause of stuck runs #1305, and its own independently-resolvedflatted@3.3.1hit a fresh curation block, making a successful release look broken.Test plan
Release (production)succeeds (npm publish completes) before this step runs and failsUpdate Appsstep