refactor(lib): remove the dead build-info.json registration read-path#455
Open
max-parke-scale wants to merge 1 commit into
Open
refactor(lib): remove the dead build-info.json registration read-path#455max-parke-scale wants to merge 1 commit into
max-parke-scale wants to merge 1 commit into
Conversation
The build-info.json read-path (`FastACP.locate_build_info_path()` → `BUILD_INFO_PATH` → `registration.get_build_info()` → merged into register_agent's `registration_metadata`) has never been fed: no producer has ever written build-info.json (the read path landed 2025-09 expecting an external build system that never materialized), so the registration git provenance has been null for ~9 months. It's also redundant: AgentexCloudDeploy.build_id is an FK to AgentexCloudBuild, so a deployment's source provenance derives from the build record over that join rather than being denormalized onto registration_metadata. Remove the read-path and the unused BUILD_INFO_PATH env var; registration_metadata still carries deployment_id and agent_card. Tracked in AGX1-419. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the never-fed
build-info.json→registration_metadataread-path.Why
build-info.json. The read path landed 2025-09 (Send build info with registration metadata #103) expecting an external build system that never materialized, so the registration git-provenance fields have been null for ~9 months.AgentexCloudDeploy.build_idis an FK toAgentexCloudBuild, so a deployment's source provenance derives from the build record (thesource_*columns AGX1-418 adds) over that join — no need to denormalize ontoregistration_metadata.What
FastACP.locate_build_info_path()+ its call inFastACP.create().registration.get_build_info()and theregistration_metadata = get_build_info()seed —registration_metadatastill carriesdeployment_id/agent_card.BUILD_INFO_PATHenv-var const/field.test_agent_card.pytests that mockedget_build_info.Full
libsuite green (877 passed);ruff/pyrightclean. Tracked in AGX1-419; the server-sideDeploymentHistorygit fields are the other (cross-team, breaking) half tracked there.🧑💻🤖 — posted via Claude Code
Greptile Summary
This PR removes the unused build-info registration metadata path. The main changes are:
BUILD_INFO_PATHfrom environment variable parsing.FastACPprobing for nearbybuild-info.jsonfiles.get_build_info()from agent registration.Confidence Score: 5/5
Safe to merge based on the scoped removal of unused build-info metadata plumbing and corresponding test updates.
The changes are narrowly focused on deleting an unfed read path while preserving deployment id and agent card registration metadata, with no issues identified in the changed behavior.
What T-Rex did
Reviews (1): Last reviewed commit: "refactor(lib): remove the dead build-inf..." | Re-trigger Greptile