Skip to content

fix: align pending_connection_errors YARD default with implementation#593

Merged
route merged 1 commit into
rubycdp:mainfrom
sngsmz:fix/pending-connection-errors-yard
Jul 1, 2026
Merged

fix: align pending_connection_errors YARD default with implementation#593
route merged 1 commit into
rubycdp:mainfrom
sngsmz:fix/pending-connection-errors-yard

Conversation

@sngsmz

@sngsmz sngsmz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes an outdated YARD default for :pending_connection_errors on Ferrum::Browser.

Location Documented default Actual default
lib/ferrum/browser.rb (before) false
lib/ferrum/browser/options.rb true
docs/2-customization.md true true

This PR aligns browser.rb with the implementation and existing docs.

Background

Test plan

  • No code behavior changes
  • Verified against options.rb and customization docs

@route route merged commit bf7a4b2 into rubycdp:main Jul 1, 2026
7 checks passed
@route

route commented Jul 1, 2026

Copy link
Copy Markdown
Member

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants