fix(ci): dispatch against main instead of deleted feature branch#67
Conversation
📝 WalkthroughWalkthroughThis change updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/actions/ecosystem_ci_dispatch/action.yaml (1)
117-127: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftFollow the SHA Pin Update Policy for
ecosystem_ci_dispatchchanges.Per the coding guidelines for
.github/actions/ecosystem_ci_dispatch/**, any change to this action requires bumpingversioninpackage.json, dispatchingrelease.ymlto cut a new tag, and then bumping the@<sha>pins in every upstream stack repo. Thisrefchange modifies the action's behavior, so the full release and pin-update process should be completed as part of this PR.As per coding guidelines: "For
.github/actions/ecosystem_ci_dispatch/**orecosystem_ci_per_commit/**changes, bumpversioninpackage.json, dispatchrelease.ymlto cut a new tag, then bump the two@<sha>pins in every upstream stack repo."🔍 Verification script
#!/bin/bash # Check if package.json exists in this action directory and whether version was bumped cat .github/actions/ecosystem_ci_dispatch/package.json 2>/dev/null || echo "package.json not found" # Search for upstream SHA pins referencing this action rg -rn 'ecosystem_ci_dispatch@' .github/ --glob '!**/ecosystem_ci_dispatch/**'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/actions/ecosystem_ci_dispatch/action.yaml around lines 117 - 127, The ref update in ecosystem_ci_dispatch changes action behavior, so complete the release workflow for this action: bump the version in the action’s package.json, dispatch release.yml to publish a new tag, and then update every upstream stack repo to use the new @<sha> pin. Make sure the pin changes are applied wherever ecosystem_ci_dispatch is referenced, using the action’s existing release/tagging flow and the identified dispatch step to locate the change.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/actions/ecosystem_ci_dispatch/action.yaml:
- Line 120: The dispatch step in the ecosystem CI action is still configured to
ignore failures, which can leave the job green even when the workflow run ID is
missing. Remove the continue-on-error setting from the dispatch step, or add
explicit failure handling after the dispatch in the same action so the job fails
when steps.dispatch.outputs.run_id is empty. Use the existing dispatch step and
its run_id output as the location to wire in the failure check.
---
Outside diff comments:
In @.github/actions/ecosystem_ci_dispatch/action.yaml:
- Around line 117-127: The ref update in ecosystem_ci_dispatch changes action
behavior, so complete the release workflow for this action: bump the version in
the action’s package.json, dispatch release.yml to publish a new tag, and then
update every upstream stack repo to use the new @<sha> pin. Make sure the pin
changes are applied wherever ecosystem_ci_dispatch is referenced, using the
action’s existing release/tagging flow and the identified dispatch step to
locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 06f44490-0caa-4986-8de9-d07929090a37
📒 Files selected for processing (1)
.github/actions/ecosystem_ci_dispatch/action.yaml
| @@ -120,7 +120,7 @@ runs: | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
continue-on-error: true still masks dispatch failures.
The PR objectives note that continue-on-error: true previously masked the dispatch failure, causing a green job while only posting a cannot determine workflow run id comment. This PR fixes the root cause (wrong ref) but leaves continue-on-error: true in place, so any future dispatch failure will still be silently swallowed and report green. Consider removing continue-on-error: true from the dispatch step — or at minimum adding a follow-up step that fails the job when steps.dispatch.outputs.run_id is empty — so failures surface explicitly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/actions/ecosystem_ci_dispatch/action.yaml at line 120, The dispatch
step in the ecosystem CI action is still configured to ignore failures, which
can leave the job green even when the workflow run ID is missing. Remove the
continue-on-error setting from the dispatch step, or add explicit failure
handling after the dispatch in the same action so the job fails when
steps.dispatch.outputs.run_id is empty. Use the existing dispatch step and its
run_id output as the location to wire in the failure check.
Why
#64 swapped the Docker
trigger-workflow-and-waitfor JSworkflow_dispatch, but left thereturn-dispatchstep inecosystem_ci_dispatchpointing at its own feature branch:That branch was deleted after #64 merged, so every from-PR dispatch now fails at the dispatch call:
continue-on-error: truemasks it as a green job, and the PR only gets acannot determine workflow run idcomment — the downstream suites never run. (Reproduced via web-infra-dev/rspack#14726 → run 28925071792.)ecosystem_ci_per_commitalready usesref: main; this aligns the dispatch variant.