Fix race condition when executing Java workspace commands during standard server startup#4462
Open
shin19991207 wants to merge 2 commits into
Open
Fix race condition when executing Java workspace commands during standard server startup#4462shin19991207 wants to merge 2 commits into
shin19991207 wants to merge 2 commits into
Conversation
…r startup Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2481
There is a race condition in extension start-up where
java.execute.workspaceCommandcan be invoked while the standard Java language server is still starting. During that startup window,standardClient.getClient()can beundefined, but the command handler callsstandardClient.getClient().sendRequest(...). That can throw:This is especially visible when standard server startup is delayed or skipped by startup decisions such as build tool conflict handling (i.e. open a project with both
build.gradleandpom.xmlexisted).This PR prevents
java.execute.workspaceCommandfrom using the Java language client before it is initialized by:java.execute.workspaceCommandwait for an active standard server startup before sending the workspace command requestpostExtensionStartInit(...)so the initial standard-server startup decision happens before commands that depend on the standard client are registered