feat: allow java.jdt.ls.java.home to use execution environment names#4445
Open
amritamishra01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows
java.jdt.ls.java.hometo accept the name of a configured Java execution environment fromjava.configuration.runtimes, in addition to accepting an absolute JDK path.Motivation
Currently,
java.jdt.ls.java.homeexpects a filesystem path. If users specify the execution environment name (for example,"JavaSE-21"), the value is treated as a path and validation fails.This change resolves the configured runtime name to its corresponding JDK path before the existing validation logic runs.
Changes
checkJavaPreferences().requirements.tsunchanged.Testing
"JavaSE-21") is resolved successfully and the Java language server starts normally.