change fork awesome to font awesome and change the social media footer#141
change fork awesome to font awesome and change the social media footer#141Coolgamerguy-tech wants to merge 50 commits into
Conversation
Coolgamerguy-tech
changed the title
learn-more
left a comment
learn-more
left a comment
There was a problem hiding this comment.
Some questions while reviewing this PR.
| <div class="col-sm-5 col-md-4 col-right"> | ||
| <div class="social"> | ||
| <a href="https://github.com/reactos" target="_blank"><i class="fab fa-github"></i></a> | ||
| <a class="youtube" href="https://youtube.com/c/ReactOSCommunity" target="_blank"><i class="fab fa-youtube"></i></a> |
There was a problem hiding this comment.
Is there a reason why you removed the class?
There was a problem hiding this comment.
fork awesome already has an effect for hover which look nice, i don't really like the current one, is there something else this class does expect adding a hover effect?
There was a problem hiding this comment.
It did add at least the hover effect, I did not investigate if this did do other stuff.
I liked the old hover effect better, it did change to logo to be colored in the 'original' color again, which is a nice touch imo.
There was a problem hiding this comment.
It did add at least the hover effect, I did not investigate if this did do other stuff. I liked the old hover effect better, it did change to logo to be colored in the 'original' color again, which is a nice touch imo.
Ok, ill see what is does, i'll try to change it a bit because some of the icons don't fit in the colored circle.
There was a problem hiding this comment.
It did add at least the hover effect, I did not investigate if this did do other stuff. I liked the old hover effect better, it did change to logo to be colored in the 'original' color again, which is a nice touch imo.
i remade the hover effect, do you like it or should I just revert to the old one? @learn-more
There was a problem hiding this comment.
I prefer the old one, but if more people like this new one that is fine with me.
| <link rel="stylesheet" href="{{ "fork-awesome/css/fork-awesome.min.css" | relURL}}"> | ||
| <link rel="stylesheet" href="{{ "fork-awesome/css/v5-compat.min.css" | relURL}}"> | ||
| <!-- Bootstrap and Font Awesome css --> | ||
| <link rel="stylesheet" href="{{ "font-awesome/css/all.min.css" | relURL}}"> |
There was a problem hiding this comment.
Do we need all versions?
We took time to minimize fork awesome, so we don't have a ton of icons we don't use.
Is e.g. the 'solid' version used?
There was a problem hiding this comment.
can you please deploy for me to test? thanks
There was a problem hiding this comment.
Do we need all versions? Is e.g. the 'solid' version used?
Yes solid is used.
| ``` | ||
|
|
||
| The `icon` field is the CSS class of an icon. In this example we have used icons powered by [ForkAwesome](https://forkaweso.me/Fork-Awesome/) 1.1.7. | ||
| The `icon` field is the CSS class of an icon. In this example we have used icons powered by [FontAwesome](http://fontawesome.io/icons/). |
There was a problem hiding this comment.
Now there is only ttf and woff2,
we included the eot, svg and woff variants for browser compatiblity.
Are they not available anymore?
Did you just not include them?
There was a problem hiding this comment.
Are they not available anymore? Did you just not include them?
they aren't available in fork awesome 6, is there a case where a browser doesn't support ttf or woff2, but support eot, svg or woff? i tested in firefox 33 and it seems to work, so do modern browser like firefox 151.
There was a problem hiding this comment.
but being a project that runs older stuff, people will not always run the latest/greatest versions.
There was a problem hiding this comment.
Pull request overview
This PR migrates the ReactOS theme’s icon assets from Fork Awesome (1.1.7) to Font Awesome Free (6.7.2) and updates the footer’s social media icons/links (including switching Twitter to X).
Changes:
- Remove the bundled Fork Awesome CSS and v5 compatibility shims.
- Add Font Awesome 6.7.2 (
all.min.css) and update the shared head partial to load it. - Update the footer social links/icons (Twitter → X) and adjust documentation references.
Reviewed changes
Copilot reviewed 7 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| themes/reactos/static/fork-awesome/css/v5-compat.min.css.map | Removes Fork Awesome v5 compatibility sourcemap. |
| themes/reactos/static/fork-awesome/css/v5-compat.min.css | Removes Fork Awesome v5 compatibility minified CSS. |
| themes/reactos/static/fork-awesome/css/v5-compat.css | Removes Fork Awesome v5 compatibility CSS source. |
| themes/reactos/static/fork-awesome/css/fork-awesome.min.css.map | Removes Fork Awesome sourcemap. |
| themes/reactos/static/fork-awesome/css/fork-awesome.min.css | Removes Fork Awesome minified CSS bundle. |
| themes/reactos/static/fork-awesome/css/fork-awesome.css | Removes Fork Awesome CSS source bundle. |
| themes/reactos/static/font-awesome/css/all.min.css | Adds Font Awesome Free 6.7.2 CSS bundle for icons/webfonts. |
| themes/reactos/README.md | Updates docs to reference Font Awesome (but needs minor corrections). |
| themes/reactos/layouts/partials/shared-head.html | Switches loaded icon stylesheet to Font Awesome. |
| themes/reactos/layouts/partials/footer.html | Updates social icons/links (including X) but currently regresses hover styling/security/accessibility attributes. |
Files not reviewed (1)
- themes/reactos/static/font-awesome/css/all.min.css: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
learn-more
added
the
deploy-pr
|
Thanks for your contribution! |
this makes the social media icon be up to date, compare to before where they were the old version and now the footer has X instead of twitter. also has more modern icons.
it should work with older browers (tested with firefox 33)