Add missing LogBox method declarations to LogBox.d.ts (#57472)#57472
Closed
Abbondanzo wants to merge 1 commit into
Closed
Add missing LogBox method declarations to LogBox.d.ts (#57472)#57472Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110930249. |
Summary: `LogBox.d.ts` declared only `ignoreLogs`, `ignoreAllLogs`, `install`, and `uninstall`, but the runtime `LogBox` object also exposes `isInstalled()` and `clearAllLogs()`. Add these two signatures so TypeScript consumers can call them without casting. Changelog: [General][Added] - Add `isInstalled()` and `clearAllLogs()` to the `LogBox` TypeScript declarations Reviewed By: christophpurrer Differential Revision: D110930249
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D110930249
branch
from
57275d3 to
7666583
Compare
|
This pull request has been merged in a69badd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LogBox.d.tsdeclared onlyignoreLogs,ignoreAllLogs,install, anduninstall, but the runtimeLogBoxobject also exposesisInstalled()andclearAllLogs(). Add these two signatures so TypeScript consumers can call them without casting.Changelog:
[General][Added] - Add
isInstalled()andclearAllLogs()to theLogBoxTypeScript declarationsReviewed By: christophpurrer
Differential Revision: D110930249