ArrayBuffer support to ObjC TurboModules #56986
Open
paradowstack wants to merge 6 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D106846249. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 28, 2026
Summary: Adds ArrayBuffer support to ObjC TurboModules, following the C++ ArrayBuffer PR ([`226ef2e`](226ef2e)). - Codegen support for `ArrayBufferTypeAnnotation` in ObjC module specs (`NSMutableData *` params/returns, new `ArrayBufferKind`) - JSI↔ObjC conversion wraps native-backed buffers zero-copy via `-[NSMutableData initWithBytesNoCopy:length:deallocator:]`; the deallocator retains the backing store so the bytes stay valid even if the `NSMutableData` escapes the call or the source ArrayBuffer is garbage-collected - JS-backed buffers are copied, which is safe on both the synchronous and asynchronous paths This PR is iOS-only; Android support follows in a separate PR. ## Changelog: [IOS] [ADDED] - Add ArrayBuffer support to ObjC TurboModules X-link: #56986 Reviewed By: javache Differential Revision: D106846249 Pulled By: christophpurrer fbshipit-source-id: 3393d5d6f31a1412f5d52328c90e51205aa6b153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds ArrayBuffer support to ObjC TurboModules, following the C++ ArrayBuffer PR (
226ef2e).ArrayBufferTypeAnnotationin ObjC module specs (NSMutableData *params/returns, newArrayBufferKind)RCTZeroCopyData—NSMutableDatasubclass for wrapping external memory without copyingisSyncflag threaded through the invocation path to select the correct conversion strategy; defaults toNO(safe copy) for call sites outside the TurboModule dispatch pathAndroid support will follow in a separate PR. This PR touches some Java parts only to get the project building.
Changelog:
[IOS] [ADDED] - Add ArrayBuffer support to ObjC TurboModules
Test Plan:
RCTTurboModuleArrayBufferTests.mmgetArrayBuffer,createNativeBuffer,processAsyncBuffer,getAsyncBufferadded toNativeSampleTurboModule