Skip to content

fix: set option list virtual prefix #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Jul 10, 2026
Merged

fix: set option list virtual prefix #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/OptionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ const OptionList: React.ForwardRefRenderFunction<RefOptionListProps, {}> = (_, r
</div>
)}
<List<FlattenOptionData<BaseOptionType>>
prefixCls={`${prefixCls}-dropdown-list`}
itemKey="key"
ref={listRef}
data={memoFlattenOptions}
Expand Down
2 changes: 1 addition & 1 deletion tests/Accessibility.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe('Select.Accessibility', () => {
}
});

const rcVirtual = document.querySelector('.rc-virtual-list-holder-inner');
const rcVirtual = document.querySelector('.rc-select-dropdown-list-holder-inner');
expect(rcVirtual).not.toHaveAttribute('role');
const rcOptionItem = rcVirtual.querySelectorAll('.rc-select-item-option');

Expand Down
8 changes: 6 additions & 2 deletions tests/OptionList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,9 @@ describe('OptionList', () => {
const { container } = render(<Select open showScrollBar options={options} />);

await waitFor(() => {
const scrollbarElement = container.querySelector('.rc-virtual-list-scrollbar-visible');
const scrollbarElement = container.querySelector(
'.rc-select-dropdown-list-scrollbar-visible',
);
expect(scrollbarElement).not.toBeNull();
});
});
Expand All @@ -573,7 +575,9 @@ describe('OptionList', () => {
const { container } = render(<Select open showScrollBar={false} options={options} />);

await waitFor(() => {
const scrollbarElement = container.querySelector('.rc-virtual-list-scrollbar-visible');
const scrollbarElement = container.querySelector(
'.rc-select-dropdown-list-scrollbar-visible',
);
expect(scrollbarElement).toBeNull();
});
});
Expand Down
12 changes: 6 additions & 6 deletions tests/Select.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ describe('Select.Basic', () => {
);

// these generate the same snapshots
expect(containerFirst.querySelector('.rc-virtual-list')).toMatchSnapshot();
expect(containerSecond.querySelector('.rc-virtual-list')).toMatchSnapshot();
expect(containerThird.querySelector('.rc-virtual-list')).toMatchSnapshot();
expect(containerFirst.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
expect(containerSecond.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
expect(containerThird.querySelector('.rc-select-dropdown-list')).toMatchSnapshot();
});
});

Expand Down Expand Up @@ -2619,7 +2619,7 @@ describe('Select.Basic', () => {
const options = new Array(10).fill(null).map((_, value) => ({ value }));

const { container } = testingRender(<Select open direction="rtl" options={options} />);
expect(container.querySelector('.rc-virtual-list-rtl')).toBeTruthy();
expect(container.querySelector('.rc-select-dropdown-list-rtl')).toBeTruthy();
});

it('Should optionRender work', () => {
Expand Down Expand Up @@ -2720,7 +2720,7 @@ describe('Select.Basic', () => {
/>,
);
const element = container.querySelectorAll<HTMLDivElement>(
'div.rc-virtual-list-holder-inner .rc-select-item',
'div.rc-select-dropdown-list-holder-inner .rc-select-item',
);
expect(element[0]).not.toHaveClass('rc-select-item-option-disabled');
expect(element[1]).toHaveClass('rc-select-item-option-disabled');
Expand Down Expand Up @@ -2811,7 +2811,7 @@ describe('Select.Basic', () => {
const prefix = container.querySelector('.rc-select-prefix');
const suffix = container.querySelector('.rc-select-suffix');
const item = container.querySelector('.rc-select-item-option');
const list = container.querySelector('.rc-virtual-list');
const list = container.querySelector('.rc-select-dropdown-list');
const input = container.querySelector('input');
expect(prefix).toHaveClass(customClassNames.prefix);
expect(prefix).toHaveStyle(customStyle.prefix);
Expand Down
12 changes: 6 additions & 6 deletions tests/__snapshots__/OptionList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ exports[`OptionList renders correctly virtual 1`] = `
/>
</div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -102,15 +102,15 @@ exports[`OptionList renders correctly virtual 1`] = `
exports[`OptionList renders correctly without virtual 1`] = `
<div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
id="undefined_list"
role="listbox"
style="display: flex; flex-direction: column;"
Expand Down
36 changes: 18 additions & 18 deletions tests/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ exports[`Select.Basic does not filter when filterOption value is false 1`] = `
</div>
</div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -265,16 +265,16 @@ exports[`Select.Basic render renders role prop correctly 1`] = `

exports[`Select.Basic render should support fieldName 1`] = `
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -312,16 +312,16 @@ exports[`Select.Basic render should support fieldName 1`] = `

exports[`Select.Basic render should support fieldName 2`] = `
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -359,16 +359,16 @@ exports[`Select.Basic render should support fieldName 2`] = `

exports[`Select.Basic render should support fieldName 3`] = `
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -433,16 +433,16 @@ exports[`Select.Basic should contain falsy children 1`] = `
</div>
</div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down Expand Up @@ -532,16 +532,16 @@ exports[`Select.Basic should render custom dropdown correctly 1`] = `
</div>
</div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down
6 changes: 3 additions & 3 deletions tests/__snapshots__/Tags.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@ exports[`Select.Tags OptGroup renders correctly 1`] = `
/>
</div>
<div
class="rc-virtual-list"
class="rc-select-dropdown-list"
style="position: relative;"
>
<div
class="rc-virtual-list-holder"
class="rc-select-dropdown-list-holder"
style="max-height: 200px; overflow-y: auto;"
>
<div>
<div
class="rc-virtual-list-holder-inner"
class="rc-select-dropdown-list-holder-inner"
style="display: flex; flex-direction: column;"
>
<div
Expand Down
Loading