Support bf16-out quantized embeddings on CPU#20707
Open
GregoryComer wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20707
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e1674d5 with merge base db5f1ba ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
GregoryComer
added
release notes: quantization
GregoryComer
changed the title
GregoryComer
requested review from
JacobSzwejbka,
larryliu0820 and
manuelcandales
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable bf16 in embedding_byte and sub-byte ops. This is a relatively simple change as templating of the actual kernels/impls make it pretty much work out of box.
Test Plan
I've added test coverage for bf16 2, 4, and 8-bit embeddings.