NXP backend: Enable sum with new Neutron flow#20700
Merged
roman-janik-nxp merged 1 commit intoJul 3, 2026
Merged
Conversation
roman-janik-nxp
requested review from
mergennachin and
robert-kalmar
as code owners
roman-janik-nxp
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20700
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e101d3d with merge base 3bd4748 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
MartinPavella
approved these changes
Jul 3, 2026
MartinPavella
left a comment
MartinPavella
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍🏻
Nit: In the PR summary you are saying you added tests for sum. I have noticed this on another PR before as well. Yes you added tests, but most importantly, you added support for the operator in the first place, so I don't think the summary is appropriate.
Collaborator
Author
|
The failing checks seem unrelated and the internal build is passing. Merging. |
roman-janik-nxp
deleted the
feature/nxg11066/EIEX-890-Add-sum-support-using-new-Neutron-flow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables support for
sum.dim_IntListby the Neutron backend using the new Neutron MLIR flow, add tests verifying correct support.Test plan
Unit tests provided.
cc @robert-kalmar