NXP backend: Use a quantized dataset for testing operators where a single-bit error is expected.#20689
Open
MartinPavella wants to merge 1 commit into
Conversation
…ngle-bit error is expected.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20689
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 71be8b9 with merge base 3bd4748 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
novak-vaclav
approved these changes
Jul 2, 2026
novak-vaclav
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, good job 👌
Nit: I was just thinking that a global decorator instead of setting remove_quant_io_ops everytime might be more beautiful, but I will leave it up to you:
from functools import wraps
def allow_one_bit_error(func):
@wraps(func)
def wrapper(self, *args, **kwargs):
self.remove_quant_io_ops = True
return func(self, *args, **kwargs)
return wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a quantized dataset for testing operators where a single-bit error is expected. With a float dataset, the error depended on the output quantization. With a quantized dataset, the tolerance is always
1, regardless of quantization.Test plan
Tested by existing nxp tests.
./backends/nxp/run_unittests.shcc @robert-kalmar @JakeStevens @digantdesai @rascani