Skip to content

ci: remove perms #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobCoffee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: remove perms #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/deployminder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ jobs:
remind:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Comment on PR
uses: actions/github-script@v7

@JacobCoffee JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should revert to v6

@ewdurbin ewdurbin Oct 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, was it working before update?

@ewdurbin ewdurbin Oct 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like we were ever using v6?

@JacobCoffee JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure anymore :\ this works on a private repo as many times as i can trigger it, but here it fails. both repos have the same perms in settings > actions, so im just confused on what the issue is.

it was working before the permissions add, then it wasn't

@JacobCoffee JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going off of https://github.com/actions/github-script?tab=readme-ov-file#comment-on-an-issue and https://github.com/litestar-org/litestar/blob/119169d1c335f68cbc4673006b4cb2aa96983513/.github/workflows/pr-merged.yml#L49

Expand Down