gh-153091: Fix os.listvolumes() should be only available for MS_WINDOWS_DESKTOP

[thexai]

FindFirstVolumeW is only supported on Windows Desktop (not in UWP).

Closes #153091

• Issue: os.listvolumes() interface should be only available on Windows Desktop (MS_WINDOWS_DESKTOP) and not in UWP (MS_WINDOWS_APP) #153091

[cmaloney]

Should also update the availability line

cpython/Doc/library/os.rst

Line 2514 in 4c79929

.. availability:: Windows

[thexai]

Should also update the availability line

Not seems necessary as all other similar functions (already limited to Windows Desktop) only mentions Windows

e.g:

cpython/Doc/library/os.rst

Lines 2492 to 2494 in 4c79929

	.. audit-event:: os.listmounts volume os.listmounts
	.. availability:: Windows

Universal Windows Platform is not mentioned nowhere because is not supported yet (officially) in all Python Core.

[thexai]

This needs backport to 3.15

[zooba]

Universal Windows Platform is not mentioned nowhere because is not supported yet (officially) in all Python Core.

Yep, this is correct. The availability in our docs only refers to the supported build configurations, which currently is just desktop.

Certainly open to changing that, but it requires at minimum a long-term reliable/maintained buildbot for the configuration, as well as a separate discussion. For now, since it's only custom builds that will hit this path, we don't bother documenting it.

[zooba]

I'm also somewhat ambivalent on NEWS entries - I don't think we need them for each one of these changes. Provided the change only converts a custom build configuration from a build failure to success, we don't really need to raise that to end users. Only if it could change a success to a failure, or has an impact on regular users, do we really need to expose it in NEWS.

[thexai]

NEWS removed.

[cmaloney]

Please don't force push to CPython PR branches

[zooba]

Also we just decided (on a backport PR) not to backport these. Hopefully you've got your own port of the changes for the 3.15 branch already - these will only be in main/3.16 sources.

[thexai]

Also we just decided (on a backport PR) not to backport these. Hopefully you've got your own port of the changes for the 3.15 branch already - these will only be in main/3.16 sources.

Then this PR can be closed as these changes are also on #152998.

The reason of opening a separated issue (#153091) is seems to me like a "bug" because it's assigned to MS_WINDOWS_APP instead of MS_WINDOWS_DESKTOP only for this function, however it's fine for other similar functions e.g: os.listmounts().

The others UWP PR's are most an improvement (not existent dedicated code path) but this one seems a bug (wrong / misasigned code path). And also in 3.15 code.

[zooba]

Okay, we'll go with the other PR then.

Because we're only really supporting Desktop upstream (in our CI/etc.), it's entirely possible that the other API partitions may not build. So we happily accept changes to fix those builds, but won't usually treat them as bugs, since they don't affect the main set of users who we communicate to (bear in mind that while our code (not builds) is the main product, our users are the recipient of the list of changes, and so we try not to clutter them up with lists of changes that don't affect them but are obvious (fail->success) to those who are impacted).