Skip to content

gh-152433: Windows: allow build overlapped.c for UWP #153036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thexai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-152433: Windows: allow build overlapped.c for UWP #153036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db8146
gh-152433: Windows: allow build ``overlapped.c`` for UWP
thexai Jul 4, 2026
feba92a
Improve NEWS entry
thexai Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Windows/2026-07-04-18-57-47.gh-issue-152433.tO5k5t.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow build :mod:`!_overlapped` module for Universal Windows Platform.
16 changes: 16 additions & 0 deletions Modules/overlapped.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@

#define T_HANDLE T_POINTER

#ifndef HasOverlappedIoCompleted
#define HasOverlappedIoCompleted(lpOverlapped) (lpOverlapped)->Internal != STATUS_PENDING
#endif

/*[python input]
class pointer_converter(CConverter):
format_unit = '"F_POINTER"'
Expand Down Expand Up @@ -359,6 +363,9 @@ _overlapped_RegisterWaitWithQueue_impl(PyObject *module, HANDLE Object,
DWORD Milliseconds)
/*[clinic end generated code: output=c2ace732e447fe45 input=2dd4efee44abe8ee]*/
{
#ifndef MS_WINDOWS_DESKTOP
return NULL;
#else
HANDLE NewWaitObject;
struct PostCallbackData data = {CompletionPort, Overlapped}, *pdata;

Expand All @@ -381,6 +388,7 @@ _overlapped_RegisterWaitWithQueue_impl(PyObject *module, HANDLE Object,
}

return Py_BuildValue(F_HANDLE, NewWaitObject);
#endif
}

/*[clinic input]
Expand All @@ -396,6 +404,9 @@ static PyObject *
_overlapped_UnregisterWait_impl(PyObject *module, HANDLE WaitHandle)
/*[clinic end generated code: output=ec90cd955a9a617d input=a56709544cb2df0f]*/
{
#ifndef MS_WINDOWS_DESKTOP
Py_RETURN_NONE;
#else
BOOL ret;

Py_BEGIN_ALLOW_THREADS
Expand All @@ -405,6 +416,7 @@ _overlapped_UnregisterWait_impl(PyObject *module, HANDLE WaitHandle)
if (!ret)
return SetFromWindowsErr(0);
Py_RETURN_NONE;
#endif
}

/*[clinic input]
Expand All @@ -422,6 +434,9 @@ _overlapped_UnregisterWaitEx_impl(PyObject *module, HANDLE WaitHandle,
HANDLE Event)
/*[clinic end generated code: output=2e3d84c1d5f65b92 input=953cddc1de50fab9]*/
{
#ifndef MS_WINDOWS_DESKTOP
Py_RETURN_NONE;
#else
BOOL ret;

Py_BEGIN_ALLOW_THREADS
Expand All @@ -431,6 +446,7 @@ _overlapped_UnregisterWaitEx_impl(PyObject *module, HANDLE WaitHandle,
if (!ret)
return SetFromWindowsErr(0);
Py_RETURN_NONE;
#endif
}

/*
Expand Down
Loading