Skip to content

[3.15] gh-98894: Check tracer exit status in test_dtrace (GH-152893) #152900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jul 2, 2026
Merged

[3.15] gh-98894: Check tracer exit status in test_dtrace (GH-152893) #152900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Lib/test/test_dtrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def generate_trace_command(self, script_file, subcommand=None):
command += ["-c", subcommand]
return command

def trace(self, script_file, subcommand=None, *, timeout=None):
def trace(self, script_file, subcommand=None, *, timeout=None,
check_returncode=False):
command = self.generate_trace_command(script_file, subcommand)
proc = create_process_group(command,
stdout=subprocess.PIPE,
Expand All @@ -136,14 +137,20 @@ def trace(self, script_file, subcommand=None, *, timeout=None):
except subprocess.TimeoutExpired:
kill_process_group(proc)
raise
if check_returncode and proc.returncode:
raise AssertionError(
f"Command {' '.join(command)!r} failed "
f"with exit code {proc.returncode}: output={stdout!r}"
)
return stdout

def trace_python(self, script_file, python_file, optimize_python=None):
python_flags = []
if optimize_python:
python_flags.extend(["-O"] * optimize_python)
subcommand = " ".join([sys.executable] + python_flags + [python_file])
return self.trace(script_file, subcommand, timeout=60)
return self.trace(script_file, subcommand, timeout=60,
check_returncode=True)

def assert_usable(self):
try:
Expand Down
Loading