gh-66335: Test uppercase IMAP4 command names#152876
Merged
serhiy-storchaka merged 1 commit intoJul 5, 2026
Merged
Conversation
Co-authored-by: Milan Oberkirch <zvyn@oberkirch.org> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added
skip news
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-153080 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-153081 is a backport of this pull request to the 3.14 branch. |
|
GH-153082 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #152872 (gh-66335).
imaplib.IMAP4.__getattr__lets a command be called under its uppercase name (client.CAPABILITY()in addition toclient.capability()), as documented, and raisesAttributeErrorfor an unknown name. This adds a test for that behavior, which the coverage PR left out.Co-authored with the author of the original bpo-22137 patch, which included this test.